🛡️ Sentinel: [CRITICAL] Fix integer overflow coercion vulnerability in readline input validation

.Rbuildignore

@@ -22,3 +22,4 @@
 ^\.jules(/.*)?$
 ^\.trivyignore\.yaml$
 ^trivy\.yaml$
+.semgrepignore

.jules/sentinel.md

@@ -2,3 +2,8 @@
 **Vulnerability:** Unvalidated inputs passed to `if()` statements can cause process crashes (`condition has length > 1`) or unexpected coercion vulnerabilities.
 **Learning:** In R, optional boolean parameters that default to `NULL` should be validated using explicit runtime type validation (e.g., `if (!is.null(flag) && (!is.logical(flag) || length(flag) != 1 || is.na(flag)))`).
 **Prevention:** Always implement explicit runtime type validation for optional boolean parameters.
+
+## 2024-07-28 - Fix integer overflow coercion in readline input validation
+**Vulnerability:** Unbounded digit class regex (e.g., `^[0-9]+$`) used for validating user input expecting a single-digit integer choice allows extremely large numeric strings to pass the regex check, which subsequently evaluate to `NA` in `as.integer(n)`. This causes a process crash due to `missing value where TRUE/FALSE needed`.
+**Learning:** When validating interactive `readline()` numeric inputs in R, unbounded regex checks allow integer overflow coercion vulnerabilities.
+**Prevention:** Strictly match against exact expected values (e.g., `^[12]$`) instead of using unbounded digit classes to ensure the input evaluates safely and correctly.

R/aFIPC.R

@@ -141,7 +141,7 @@ autoFIPC <-
       }
       for (attempt in seq_len(3)) {
         n <- readline(prompt = "Is it correct? (1: Yes 2: No) : ")
-        if (grepl("^[0-9]+$", n)) {
+        if (grepl("^[12]$", n)) {
           return(as.integer(n))
         }
       }
@@ -171,7 +171,7 @@ autoFIPC <-
               readline(
                 prompt = "Do you want to use default BILOG-MG priors for oldform Data? (1: Yes 2: No) : "
               )
-            if (grepl("^[0-9]+$", n)) {
+            if (grepl("^[12]$", n)) {
               return(as.integer(n))
             }
           }
@@ -390,7 +390,7 @@ autoFIPC <-
               readline(
                 prompt = "Do you want to use default BILOG-MG priors for newform Data? (1: Yes 2: No) : "
               )
-            if (grepl("^[0-9]+$", n)) {
+            if (grepl("^[12]$", n)) {
               return(as.integer(n))
             }
           }