fix(coverage): validate nested npm metadata through canonical pins - #807
Draft
seonghobae wants to merge 1 commit into
Draft
fix(coverage): validate nested npm metadata through canonical pins#807seonghobae wants to merge 1 commit into
seonghobae wants to merge 1 commit into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Central changed-head npm-lock validation currently requires every non-link
node_moduleslocation to repeat its own registry tarball and SHA-512 integrity. npm v3 can serialize workspace or peer locations with only version/classification metadata while one canonical package location carries the actual artifact pin. BandScope's validapps/desktop/node_modules/@types/react-domentry therefore blocks central coverage even though the canonical root entry is hash-bounded.Intended focused contract
CHANGELOG.md;TDD state
A bounded self-removing workflow on the branch adds the permanent tests, proves the BandScope-shaped case fails against current protected
main, applies the minimal production change, executes the full central quality suite, removes itself, and publishes only the four permanent source/test/documentation files. Keep Draft until that workflow-free exact head exists.Standards basis
The decision follows npm CLI v11's official
package-lock.jsonformat, which definespackagesas location-keyed descriptors and explicitly notes that some dependency locations may omit artifact fields while retaining metadata. The central policy remains stricter than generic npm by requiring every accepted metadata-only location to resolve to one exact canonical public-registry SHA-512 pin.Merge gate
No predecessor-head evidence is accepted. Require workflow-free current head, full central tests, 100% production statement/branch/docstring evidence, compilation, Ruff, all security/supply-chain gates, OpenCode, Noema, CodeRabbit, zero actionable threads, a qualifying non-author approval, and branch protection without bypass.
Refs ContextualWisdomLab/bandscope#751 and #748.