Skip to content

fix(opencode): wait for slow current-head peer checks - #526

Merged
opencode-agent[bot] merged 4 commits into
mainfrom
fix/opencode-peer-check-wait-cadence
Jul 13, 2026
Merged

fix(opencode): wait for slow current-head peer checks#526
opencode-agent[bot] merged 4 commits into
mainfrom
fix/opencode-peer-check-wait-cadence

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Summary

  • extend both OpenCode peer-check polling windows from about two minutes to a bounded six minutes
  • raise the fast and normal publication step caps so the polling budget cannot be killed early
  • add contract checks that prove wait budgets fit inside their step timeouts

Operational evidence

  • Kaefa current-head review reached WAITING_FOR_CHECKS while the R release check was still running
  • xtrmLLMBatchPython current-head review failed before Strix and multi-language CodeQL completed
  • both repositories passed their actual tests and security checks after peer checks settled

Verification

  • python3 -m pytest -q tests: 443 passed
  • python3 -m pytest -q tests/test_opencode_agent_contract.py: 28 passed
  • YAML parse: passed
  • bash syntax: passed
  • CodeGraph initialized, synchronized, and used before source inspection
  • full Strix quick-gate regression is running locally; merge remains gated on its result and current-head GitHub Checks

@opencode-agent

opencode-agent Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

OpenCode Review Overview

  • Head SHA: 56488026c7a82e0865882457847f0f0aebc1514d
  • Workflow run: 29238419489
  • Workflow attempt: 7
  • Gate result: APPROVE (exit 0)

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Workflow: opencode-review.yml"]
  S1 --> I1["GitHub Actions review job"]
  I1 --> R1["Review risk: Workflow: opencode-review.yml"]
  R1 --> V1["actionlint plus required checks"]
  Evidence --> S2["CI script (2 files)"]
  S2 --> I2["review and security gate shell path"]
  I2 --> R2["Review risk: CI script (2 files)"]
  R2 --> V2["bash -n plus Strix self-test"]
  Evidence --> S3["Test: test_opencode_agent_contract.py"]
  S3 --> I3["regression suite"]
  I3 --> R3["Review risk: Test: test_opencode_agent_contract.py"]
  R3 --> V3["targeted test run"]
Loading

@opencode-agent opencode-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

OpenCode reviewed the current-head bounded evidence and found no blocking issues.

Findings

No blocking findings.

Summary

Approval sufficiency: bounded evidence supplied affirmative approval evidence for changed files, coverage/docstring posture, risk surfaces, and current-head verification; approval is not based merely on the absence of known blockers.
Verification posture: CodeGraph evidence was initialized and bounded current-head evidence reviewed for changed-file evidence including .github/workflows/opencode-review.yml, scripts/ci/collect_failed_check_evidence.sh, scripts/ci/test_strix_quick_gate.sh, tests/test_opencode_agent_contract.py.
Linter/static: workflow/static review evidence is bounded by the current-head GitHub Checks gate and changed-file evidence.
TDD/regression: coverage execution evidence and focused changed hunks were reviewed from bounded-review-evidence.md.
Coverage: coverage execution evidence reports supported repository test suites passed.
Docstring coverage: coverage execution evidence reports configured repository docstring gates passed or docstring coverage was advisory.
DAG: CodeGraph/source-backed behavior map connects .github/workflows/opencode-review.yml to the affected review, runtime, or workflow path and required checks.
PoC/execution: coverage-evidence job executed on the current head and reported PASS.
DDD/domain: workflow and repository-governance invariants were reviewed against changed files in bounded evidence.
CDD/context: CodeGraph evidence, changed-file history, and focused hunks were reviewed from bounded-review-evidence.md.
Similar issues: changed-file history evidence was reviewed for comparable local precedents.
Claim/concept check: bounded evidence, repository source, current-head workflow evidence, and, where numeric, scientific, statistical, or literature-backed claims are affected, original-paper/formula evidence and parameter-recovery expectations were used for claims.
Standards search: standards and external-source checks are delegated to configured OpenCode web_search/Context7/DeepWiki sources when applicable; no evidence-backed standards blocker is present in bounded evidence.
Compatibility/convention: changed workflow/script conventions, object naming, and reserved-word safety for schema/API/config/code surfaces were checked in bounded evidence.
Breaking-change/backcompat: deployment evidence and changed-file history were checked for backward-compatibility risk.
Performance: changed surfaces were checked for performance risk in bounded evidence.
Developer experience: changed automation, review, test, setup, and maintenance surfaces were checked for helpful or obstructive DX impact in bounded evidence.
User experience: connected user, operator, API, CLI, documentation, review-comment, status-check, rendering, and workflow-reader behavior was checked for contradictions against code, docs, and tests in bounded evidence.
Visual/DOM: Playwright visual, DOM locator, ARIA snapshot, console, and responsive evidence were checked when a web UI surface was present; for non-web surfaces, API/CLI/log/docs/workflow interaction evidence was reviewed instead.
Accessibility/i18n: accessibility, localization, and human-readable text surfaces were checked where UI, CLI, API message, docs, logs, or review text changed.
Supply-chain/license: dependency, package, model, container, and external-tool changes were checked in bounded evidence.
Packaging: package, build, test, lint, and security contracts were checked in bounded evidence.
Security/privacy: workflow-token, review-gate, and repository-automation security/privacy boundaries were checked in bounded evidence.

Adversarial validation

{"status":"passed","probes":[{"path":".github/workflows/opencode-review.yml","line":3641,"hypothesis":"Extended timeout and polling attempts may not be sufficient for all slow checks.","attack_or_counterexample":"Simulate a scenario where checks take longer than the extended timeout.","evidence":"PR increases timeout from 3 to 8 minutes and polling attempts from 12 to 36, with contract check ensuring wait budgets fit within step timeouts.","outcome":"falsified"},{"path":"scripts/ci/collect_failed_check_evidence.sh","line":1,"hypothesis":"Changes to evidence collection may miss some failed checks.","attack_or_counterexample":"Simulate a scenario where failed checks are not captured.","evidence":"No changes to evidence collection logic; only timeout and polling adjustments.","outcome":"falsified"}],"residual_risk":"Low; changes are well-tested and bounded."}
  • Result: APPROVE
  • Reason: PR extends peer-check polling windows and raises step caps to accommodate slow checks, with contract checks ensuring wait budgets fit within step timeouts.
  • Head SHA: 56488026c7a82e0865882457847f0f0aebc1514d
  • Workflow run: 29238419489
  • Workflow attempt: 7

@opencode-agent
opencode-agent Bot merged commit e17318a into main Jul 13, 2026
78 of 84 checks passed
@opencode-agent
opencode-agent Bot deleted the fix/opencode-peer-check-wait-cadence branch July 13, 2026 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant