Feature: Remove vertx as a dependency / transitive deps via tuweni - #238
Open
garyschulte wants to merge 1 commit into
Open
Feature: Remove vertx as a dependency / transitive deps via tuweni#238garyschulte wants to merge 1 commit into
garyschulte wants to merge 1 commit into
Conversation
Signed-off-by: garyschulte <garyschulte@gmail.com>
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
macfarla
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
remove vertx as an explicit dependency and instead rely on transitive deps from tuweni. This prevents pulling in multiple versions of vertx into discovery, tuweni, besu.
vertx has not been a direct dependency since #139, four years ago
Ideally this PR will wait to merge until tuweni is updated to the latest vertx in 65 and version 2.8.0 released.
Fixed Issue(s)
Note
Low Risk
Gradle-only dependency graph change with no application code edits; classpath still includes Vert.x transitively if Tuweni requires it.
Overview
Removes the direct
io.vertx:vertx-coredependency frombuild.gradleand deletes its4.5.9version pin ingradle/versions.gradle.Vert.x is expected to arrive only as a transitive dependency (via Tuweni), so Discovery, Tuweni, and Besu are less likely to resolve conflicting Vert.x versions on the classpath.
Reviewed by Cursor Bugbot for commit 7816d7f. Bugbot is set up for automated code reviews on this repo. Configure here.