Skip to content

docs: update connector name and style to match docs site#31

Merged
mindymo merged 2 commits into
mainfrom
fix/docs-style-updates
Jun 9, 2026
Merged

docs: update connector name and style to match docs site#31
mindymo merged 2 commits into
mainfrom
fix/docs-style-updates

Conversation

@mindymo

@mindymo mindymo commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Summary

Syncs docs/connector.mdx with the canonical docs site.

Changes include:

  • Updated connector/product name in title, og:title, description, og:description, and sidebarTitle
  • Style updates (ECR image URL, **Done.** phrasing, icon color, C1 branding)

The docs site is the source of truth for connector page content.

Comment thread docs/connector.mdx
Comment on lines 16 to 19
| :--- | :--- | :--- |
| Users | <Icon icon="square-check" iconType="solid" color="#c937ae"/> | |
| Admins | <Icon icon="square-check" iconType="solid" color="#c937ae"/> | |
| Accounts | <Icon icon="square-check" iconType="solid" color="#c937ae"/> | |
| Roles | <Icon icon="square-check" iconType="solid" color="#c937ae"/> | |
| Groups | <Icon icon="square-check" iconType="solid" color="#c937ae"/> | <Icon icon="square-check" iconType="solid" color="#c937ae"/> |

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 Bug: The capabilities table now omits Users and Admins, but both resource types are actively synced by the connector — userBuilder and adminBuilder are registered in ResourceSyncers() (pkg/connector/connector.go:58-64). Removing them from the docs makes the documentation inaccurate. These rows should be kept.

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Connector PR Review: docs: update connector name and style to match docs site

Blocking Issues: 0 | Suggestions: 0 | Threads Resolved: 0
Review mode: incremental since 1f99f34
View review run

Review Summary

The new commit restores the Users and Admins rows to the capabilities table in docs/connector.mdx, addressing the previous review finding. The table now accurately matches the five resource types registered in ResourceSyncers(). No new issues found.

Security Issues

None found.

Correctness Issues

None found.

Suggestions

None.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking issues found — see review comments.

@mindymo mindymo dismissed github-actions[bot]’s stale review June 9, 2026 23:44

Issue fixed in follow-up commit; re-review passed.

@mindymo mindymo merged commit f4cecf8 into main Jun 9, 2026
9 checks passed
@mindymo mindymo deleted the fix/docs-style-updates branch June 9, 2026 23:44

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking issues found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant