Correct finite-Q multiband G4 accumulation - #373
Open
PeizhiMai wants to merge 1 commit into
Open
Conversation
maierta
reviewed
Aug 12, 2026
maierta
left a comment
maierta
left a comment
Contributor
There was a problem hiding this comment.
This generally looks good to me, but one question I don't remember the answer to: Did the "plaquette test" pass with these changes?
Contributor
Author
Yes, the "plaquette test" pass with these changes. |
Contributor
|
Would you be able to write a test that implements the plaquette test? |
Contributor
Author
|
In my previous plaquette test, I work with converged G and G4. But here you probably want a test using only a few measurements, is that right? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct finite-Q multiband G4 accumulation (PARTICLE_PARTICLE_UP_DOWN channel only) for both CPU and GPU code.