Skip to content

Achievement Notification - #475

Open
Enorovan wants to merge 2 commits into
masterfrom
achievement-notification
Open

Achievement Notification#475
Enorovan wants to merge 2 commits into
masterfrom
achievement-notification

Conversation

@Enorovan

@Enorovan Enorovan commented May 17, 2026

Copy link
Copy Markdown
Member
  • Add a Custom Notification that can queue.
  • Be able to render Text directly from the font on the notification.
  • Don't call anything game specific.

@Enorovan Enorovan linked an issue May 17, 2026 that may be closed by this pull request
@Enorovan
Enorovan force-pushed the achievement-notification branch from 1771132 to 274e6c9 Compare May 24, 2026 21:29
@Enorovan
Enorovan force-pushed the achievement-notification branch from e5d340a to 56e5596 Compare June 1, 2026 12:15
@Enorovan Enorovan self-assigned this Jun 13, 2026
@Enorovan
Enorovan force-pushed the achievement-notification branch 2 times, most recently from 5101d4a to b51a75b Compare June 14, 2026 12:36
@Enorovan
Enorovan marked this pull request as ready for review June 14, 2026 13:45
@Enorovan
Enorovan force-pushed the achievement-notification branch 2 times, most recently from cedf387 to e0fbffe Compare August 4, 2026 13:13
Comment thread src/game.cpp Outdated
Comment thread src/hud/achievementnotification.cpp Outdated
Comment thread src/hud/achievementnotification.cpp Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should consider renaming the games folder to resources, i think that's a lot more applicable now that gamedata is external

Comment thread src/hud/achievementnotification.cpp Outdated
Comment thread src/hud/achievementnotification.cpp Outdated
@Enorovan
Enorovan force-pushed the achievement-notification branch 2 times, most recently from c4e63a9 to 31f7510 Compare August 10, 2026 16:47
Comment thread src/profile/hud/achievementnotification.cpp Outdated
@Enorovan
Enorovan force-pushed the achievement-notification branch 2 times, most recently from 1aa1802 to 14aad54 Compare August 12, 2026 10:05
Comment thread src/vm/inst_misc.cpp
Comment thread src/hud/achievementnotification.cpp Outdated
Comment thread src/externalfont.cpp Outdated
Comment thread src/externalfont.cpp
Comment thread src/externalfont.cpp
Comment thread src/font.h Outdated
Comment thread src/font.h
glm::vec4 Tint;
};

class ExternalFont {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it would be possible to have ExternalFont implement Font? I tried to write the base such that it could support vector fonts

Comment thread src/hud/achievementnotification.cpp Outdated
@Enorovan
Enorovan force-pushed the achievement-notification branch from 3441687 to 43fcfa5 Compare August 12, 2026 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a common Achievement Notification

3 participants