Add Sage Attention (CORE-74)#42
Open
contentis wants to merge 10 commits into
Open
Conversation
…or new FP8 kernels, improve error handling in sage_sdpa, and streamline quantization kernels. Also, fix exception types in tests for better clarity.
Resolve conflicts by keeping Sage Attention kernels alongside main's SVDQuant W4A4, AWQ W4A16, and split-half RoPE APIs.
Contributor
Author
|
@rattus128 any thoughts? If you think there are any critical features missing please let me know. |
|
I have to use different sage attention because I'm on ampere/turning. Will this conflict? Can i still use my own? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the kernel for SageAttention 2 using FP8 and slighlty updated quantization kernels for improved end-to-end performance.