Skip to content

Update metrics dependency #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jryan128 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update metrics dependency #191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ac4d012
Update metrics
jryan128 Jun 30, 2022
5cb1646
Update metrics
jryan128 Jun 30, 2022
4ee16ca
Just remove metrics handlers
jryan128 Jun 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ lazy val moneyCore =
Seq(
slf4j,
log4jbinding,
metricsCore,
openTelemetryApi,
openTelemetrySemConv,
typesafeConfig
Expand All @@ -74,7 +73,6 @@ lazy val moneyOtelFormatters =
Seq(
slf4j,
log4jbinding,
metricsCore,
openTelemetryApi,
openTelemetryProp,
typesafeConfig
Expand Down
55 changes: 0 additions & 55 deletions money-core/src/main/scala/com/comcast/money/core/handlers/MetricsSpanHandler.scala
View file
Open in desktop

This file was deleted.

71 changes: 0 additions & 71 deletions money-core/src/main/scala/com/comcast/money/core/metrics/MetricRegistryFactory.scala
View file
Open in desktop

This file was deleted.

70 changes: 0 additions & 70 deletions money-core/src/test/scala/com/comcast/money/core/handlers/MetricsHandlerSpec.scala
View file
Open in desktop

This file was deleted.

79 changes: 0 additions & 79 deletions money-core/src/test/scala/com/comcast/money/core/metrics/MetricRegistryFactorySpec.scala
View file
Open in desktop

This file was deleted.

5 changes: 1 addition & 4 deletions project/Dependencies.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import sbt._
object Dependencies {
val metricsV = "3.2.6"
val metricsV = "4.2.10"
val apacheHttpClientV = "4.5.6"

val akkaV = "2.5.32"
Expand Down Expand Up @@ -34,9 +34,6 @@ object Dependencies {
// Typseafe config
def typesafeConfig = "com.typesafe" % "config" % typesafeConfigV

// Codahale metrics
val metricsCore = "io.dropwizard.metrics" % "metrics-core" % metricsV

// Apache http client
val apacheHttpClient = "org.apache.httpcomponents" % "httpclient" % apacheHttpClientV

Expand Down