N°9169 - adapt itsm designer connector to the new setup

[eespie]

Add Return to Designer buttons in the setup wizard and the "Extensions management" module.

[greptile-apps]

Greptile Summary

This PR adds Designer return navigation to setup and extension cleanup flows. It changes:

• Adds Return to Designer buttons in setup wizard steps.
• Hides or disables back navigation when the Designer return path is active.
• Passes return-button state through the data feature removal flow.
• Updates the analysis result page to show either the Designer return button or the normal back-to-main form.

Confidence Score: 4/5

This is close, but the error path should be fixed before merging.

• The normal Designer return flow is mostly wired through the changed setup pages.

• The analysis error page can render a Return button without a usable target.

• Existing reported escaping and token compatibility comments still cover separate issues.

• datamodels/2.x/combodo-data-feature-removal/src/Controller/DataFeatureRemovalController.php

Important Files Changed

Filename	Overview
datamodels/2.x/combodo-data-feature-removal/src/Controller/DataFeatureRemovalController.php	Adds the static Designer return URL for analysis results, but assigns it too late for early error rendering.
datamodels/2.x/combodo-data-feature-removal/templates/AnalysisResult.html.twig	Switches the analysis footer between the Designer return button and the normal back-to-main form.

_{Reviews (2): Last reviewed commit: "N°9169 - Adapt ITSM designer connector t..." | Re-trigger Greptile}

[Copilot]

Pull request overview

Adds support for a “Return to Designer” action across the setup wizard flow and the Data Feature Removal (“Extensions management”) screens, aligning wizard navigation/back-button behavior with the new setup requirements.

Changes:

• Introduces return_button_label / return_button_url wizard parameters and injects an extra “return” button in relevant wizard steps.
• Refactors wizard backward-navigation semantics from CanComeBack() to CanMoveBackward() and updates the controller/UI accordingly.
• Updates the Data Feature Removal analysis result UI and setup-token validation path to support coming from the setup wizard.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
setup/wizardsteps/WizStepWelcome.php	Updates welcome-step UI button styling and removes an unused import.
setup/wizardsteps/WizStepSummary.php	Adds backward-navigation gating + injects “Return” button on the summary screen.
setup/wizardsteps/WizStepLandingBeforeAudit.php	Renames backward-navigation hook to CanMoveBackward().
setup/wizardsteps/WizStepInstall.php	Adds backward-navigation gating + injects “Return” button and adjusts async completion scripts.
setup/wizardsteps/WizStepDone.php	Explicitly disables backward navigation via JS.
setup/wizardsteps/WizStepDataAudit.php	Disables backward navigation, adds hidden return params, updates token field name, and injects “Return” button.
setup/wizardsteps/WizardStep.php	Removes legacy CanComeBack() and relies on CanMoveBackward() instead.
setup/wizardcontroller.class.inc.php	Uses CanMoveBackward() for history stack push and renders hidden back button cell when needed.
setup/setup.js	Changes wizard button updates to hide/show (CSS class) instead of enable/disable.
datamodels/2.x/combodo-data-feature-removal/templates/AnalysisResult.html.twig	Shows a “Return” action instead of the “Back to main” form when return params are present.
datamodels/2.x/combodo-data-feature-removal/src/Controller/DataFeatureRemovalController.php	Switches setup-entry validation to CheckSetupToken() with fallback to transaction validation; adds return params passthrough defaults.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Lenaick]

@greptileai