Skip to content

N°9663 - improved translation for zh_cn#913

Merged
jf-cbd merged 50 commits into
Combodo:developfrom
purplegrape:develop
Jun 8, 2026
Merged

N°9663 - improved translation for zh_cn#913
jf-cbd merged 50 commits into
Combodo:developfrom
purplegrape:develop

Conversation

@purplegrape

@purplegrape purplegrape commented May 20, 2026

Copy link
Copy Markdown
Contributor
  1. improved translations
  2. fix some missing entries
  3. fix some missing contents
  4. delete some out-date entries
  5. line number and indentation adjustment

@purplegrape purplegrape reopened this May 31, 2026
@github-project-automation github-project-automation Bot moved this from Finished to Pending technical review in Combodo PRs dashboard May 31, 2026
@purplegrape

Copy link
Copy Markdown
Contributor Author

this pr closed due to re-sync my fork
so have to redo the commits and reopen the pr.

@purplegrape

Copy link
Copy Markdown
Contributor Author

@jf-cbd could you plz review this pr?

@jf-cbd jf-cbd moved this from Pending technical review to Pending review in Combodo PRs dashboard Jun 5, 2026
@jf-cbd jf-cbd changed the title improved translation for zh_cn N°9663 - improved translation for zh_cn Jun 5, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Simplified Chinese (zh_cn) localization across iTop core, UI pages/layouts, and multiple 2.x modules, aiming to improve wording, fill missing entries, and adjust formatting/indentation. It also introduces new zh_cn dictionary files for additional modules.

Changes:

  • Updated numerous zh_cn dictionary strings (core + UI + 2.x modules), including several missing keys.
  • Added/updated translation entries related to Newsroom / Notifications Center and related errors.
  • Performed formatting/indentation alignment and added new zh_cn dictionary files for itop-flow-map and itop-container-mgmt.

Reviewed changes

Copilot reviewed 45 out of 45 changed files in this pull request and generated 16 comments.

Show a summary per file
File Description
dictionaries/zh_cn.dictionary.itop.core.php Core zh_cn dictionary updates, new entries, and formatting adjustments
dictionaries/ui/pages/preferences/zh_cn.dictionary.itop.preferences.php Preferences page zh_cn wording + alignment changes
dictionaries/ui/pages/notifications-center/zh_cn.dictionary.itop.notifications-center.php Notifications Center page zh_cn translation completion
dictionaries/ui/pages/login/zh_cn.dictionary.itop.login.php Login/reset password zh_cn wording tweak
dictionaries/ui/layouts/navigation-menu/zh_cn.dictionary.itop.navigation-menu.php Navigation menu zh_cn wording/spacing adjustments
dictionaries/ui/layouts/activity-panel/zh_cn.dictionary.itop.activity-panel.php Activity panel zh_cn wording tweaks
dictionaries/ui/application/welcome-popup/zh_cn.dictionary.itop.welcome-popup.php Welcome popup zh_cn translation completion
dictionaries/ui/application/newsroom/zh_cn.dictionary.itop.newsroom.php Newsroom zh_cn translation completion
dictionaries/ui/application/links/zh_cn.dictionary.itop.links.php UI links modal/button zh_cn wording + alignment changes
dictionaries/core/uniqueness-rule/zh_cn.dictionary.itop.uniqueness-rule.php Uniqueness rule zh_cn wording update
dictionaries/core/orm-value/orm-document/zh_cn.dictionary.itop.orm-document.php ORM document zh_cn string cleanup
datamodels/2.x/itop-virtualization-mgmt/dictionaries/zh_cn.dict.itop-virtualization-mgmt.php Virtualization module zh_cn additions/updates
datamodels/2.x/itop-tickets/dictionaries/zh_cn.dict.itop-tickets.php Tickets module zh_cn wording + formatting adjustments
datamodels/2.x/itop-themes-compat/dictionaries/zh_cn.dict.itop-themes-compat.php Themes compat zh_cn label tweak
datamodels/2.x/itop-structure/dictionaries/zh_cn.dict.itop-structure.php Structure module zh_cn wording + many description updates
datamodels/2.x/itop-storage-mgmt/dictionaries/zh_cn.dict.itop-storage-mgmt.php Storage mgmt zh_cn field labels completion
datamodels/2.x/itop-service-mgmt/dictionaries/zh_cn.dict.itop-service-mgmt.php Service mgmt zh_cn wording + some added attributes
datamodels/2.x/itop-service-mgmt-provider/dictionaries/zh_cn.dict.itop-service-mgmt-provider.php Service mgmt provider zh_cn wording adjustments
datamodels/2.x/itop-request-mgmt/dictionaries/zh_cn.dict.itop-request-mgmt.php Request mgmt zh_cn naming/labels updates
datamodels/2.x/itop-request-mgmt-itil/dictionaries/zh_cn.dict.itop-request-mgmt-itil.php Request mgmt ITIL zh_cn naming/labels updates
datamodels/2.x/itop-problem-mgmt/dictionaries/zh_cn.dict.itop-problem-mgmt.php Problem mgmt zh_cn formatting/spacing touch-up
datamodels/2.x/itop-portal/dictionaries/zh_cn.dict.itop-portal.php Portal zh_cn formatting/spacing touch-up
datamodels/2.x/itop-portal-base/dictionaries/zh_cn.dict.itop-portal-base.php Portal base zh_cn wording update
datamodels/2.x/itop-oauth-client/dictionaries/zh_cn.dict.itop-oauth-client.php OAuth client zh_cn spacing/formatting adjustments
datamodels/2.x/itop-knownerror-mgmt/dictionaries/zh_cn.dict.itop-knownerror-mgmt.php Known error mgmt zh_cn wording update
datamodels/2.x/itop-incident-mgmt-itil/dictionaries/zh_cn.dict.itop-incident-mgmt-itil.php Incident mgmt ITIL zh_cn wording update
datamodels/2.x/itop-hub-connector/dictionaries/zh_cn.dict.itop-hub-connector.php Hub connector zh_cn spacing/formatting adjustments
datamodels/2.x/itop-flow-map/dictionaries/zh_cn.dict.itop-flow-map.php New zh_cn dictionary file for flow-map module
datamodels/2.x/itop-faq-light/dictionaries/zh_cn.dict.itop-faq-light.php FAQ light zh_cn header/spacing adjustments
datamodels/2.x/itop-core-update/dictionaries/zh_cn.dict.itop-core-update.php Core update zh_cn wording improvements
datamodels/2.x/itop-container-mgmt/dictionaries/zh_cn.dict.itop-container-mgmt.php New zh_cn dictionary file for container mgmt module
datamodels/2.x/itop-config/dictionaries/zh_cn.dict.itop-config.php Config editor zh_cn wording/spacing adjustments
datamodels/2.x/itop-config-mgmt/dictionaries/zh_cn.dict.itop-config-mgmt.php Config mgmt zh_cn wording expansion + formatting
datamodels/2.x/itop-change-mgmt/dictionaries/zh_cn.dict.itop-change-mgmt.php Change mgmt zh_cn wording tweak
datamodels/2.x/itop-change-mgmt-itil/dictionaries/zh_cn.dict.itop-change-mgmt-itil.php Change mgmt ITIL zh_cn spacing/formatting touch-up
datamodels/2.x/itop-bridge-cmdb-ticket/dictionaries/zh_cn.dict.itop-bridge-cmdb-ticket.php CMDB-ticket bridge zh_cn wording and header formatting
datamodels/2.x/itop-bridge-cmdb-services/dictionaries/zh_cn.dict.itop-bridge-cmdb-services.php CMDB-services bridge zh_cn wording update
datamodels/2.x/itop-backup/dictionaries/zh_cn.dict.itop-backup.php Backup module zh_cn wording improvements
datamodels/2.x/itop-attachments/dictionaries/zh_cn.dict.itop-attachments.php Attachments module zh_cn wording + header update
datamodels/2.x/combodo-db-tools/dictionaries/zh_cn.dict.combodo-db-tools.php DB tools zh_cn wording updates
datamodels/2.x/combodo-backoffice-fullmoon-tritanopia-theme/dictionaries/zh_cn.dict.combodo-backoffice-fullmoon-tritanopia-theme.php Theme label zh_cn translation update
datamodels/2.x/combodo-backoffice-fullmoon-protanopia-deuteranopia-theme/dictionaries/zh_cn.dict.combodo-backoffice-fullmoon-protanopia-deuteranopia-theme.php Theme label zh_cn translation update
datamodels/2.x/combodo-backoffice-fullmoon-high-contrast-theme/dictionaries/zh_cn.dict.combodo-backoffice-fullmoon-high-contrast-theme.php Theme label zh_cn translation update
datamodels/2.x/combodo-backoffice-darkmoon-theme/dictionaries/zh_cn.dict.combodo-backoffice-darkmoon-theme.php Theme label zh_cn translation update

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread dictionaries/zh_cn.dictionary.itop.core.php
Comment thread dictionaries/zh_cn.dictionary.itop.core.php
Comment thread dictionaries/zh_cn.dictionary.itop.core.php
Comment thread dictionaries/zh_cn.dictionary.itop.core.php Outdated
Comment thread dictionaries/zh_cn.dictionary.itop.core.php Outdated
Comment thread dictionaries/zh_cn.dictionary.itop.core.php Outdated
jf-cbd and others added 2 commits June 5, 2026 16:21
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@jf-cbd

jf-cbd commented Jun 5, 2026

Copy link
Copy Markdown
Member

Hey @purplegrape, thanks for your PR !
Sounds good to me, could you please tell me if you could fix the 3 suggestions ? (2 mixes of languages + 1 translation that would be a good idea).
Thank you :)

@purplegrape

Copy link
Copy Markdown
Contributor Author

Hey @purplegrape, thanks for your PR ! Sounds good to me, could you please tell me if you could fix the 3 suggestions ? (2 mixes of languages + 1 translation that would be a good idea). Thank you :)

copilot's translation is not so good for me.
we can ignore it for the time.

@jf-cbd

jf-cbd commented Jun 8, 2026

Copy link
Copy Markdown
Member

Thanks for your feedback :)

	'Class:ActionEmail/Attribute:cc+'                       => '抄送: 返回含有邮箱字段对象的OQL查询.
编辑时可点击放大镜图标获取参考示例.
You can use in the OQL :this->attribute_code with an attribute code of the object which triggered the Notification. Then test your OQL syntax using the play icon.~~',

For this entry, and also for 'Class:ActionEmail/Attribute:to+', the translation string contains 2 languages and '~~' (while it's different from the English translation), do you think an appropriate Chinese translation would fit ? Or should I fallback to English ?

@purplegrape

purplegrape commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for your feedback :)

	'Class:ActionEmail/Attribute:cc+'                       => '抄送: 返回含有邮箱字段对象的OQL查询.
编辑时可点击放大镜图标获取参考示例.
You can use in the OQL :this->attribute_code with an attribute code of the object which triggered the Notification. Then test your OQL syntax using the play icon.~~',

For this entry, and also for 'Class:ActionEmail/Attribute:to+', the translation string contains 2 languages and '~~' (while it's different from the English translation), do you think an appropriate Chinese translation would fit ? Or should I fallback to English ?

keep it untouched.
for enries end with ~~ , itop will fallback to read entries in en.dict.*php instead.

@jf-cbd

jf-cbd commented Jun 8, 2026

Copy link
Copy Markdown
Member

Yes but we have unit test that checks that entries with '~~' are the exact same one that the English one. So I'll set the translation to English and merge your PR.
Thanks for your contribution !

@jf-cbd jf-cbd merged commit 4371ddf into Combodo:develop Jun 8, 2026
@github-project-automation github-project-automation Bot moved this from Pending review to Finished in Combodo PRs dashboard Jun 8, 2026
@jf-cbd

jf-cbd commented Jun 8, 2026

Copy link
Copy Markdown
Member

Thank you @purplegrape for this contribution !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants