Skip to content

fix(coolwsd): listen on loopback only #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
joshtrichards wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix(coolwsd): listen on loopback only #342

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion proxy.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,8 @@ function startCoolwsd()
$remoteFontConfig = "--o:remote_font_config.url=" . $remoteFontConfigUrl;
}

$loopback = "--o:net.listen=loopback";

// Check if IPv6 has been disabled
$IPv4only = "";
$launchCmd = "ip -6 addr";
Expand All @@ -102,7 +104,7 @@ function startCoolwsd()
// when lok_allow does not contain the Nextcloud host, it is not possible to insert image from Nextcloud
// we have to set explicitly, because storage.wopi.alias_groups[@mode] is 'first' in case of richdocumentscode
$lok_allow = "--o:net.lok_allow.host[14]=" . escapeshellarg($_SERVER['HTTP_HOST']);
$launchCmd = "bash -c \"( $appImage $remoteFontConfig $IPv4only $lok_allow --pidfile=$pidfile || $appImage --appimage-extract-and-run $remoteFontConfig $IPv4only $lok_allow --pidfile=$pidfile) >/dev/null & disown\"";
$launchCmd = "bash -c \"( $appImage $remoteFontConfig $IPv4only $loopback $lok_allow --pidfile=$pidfile || $appImage --appimage-extract-and-run $remoteFontConfig $IPv4only $loopback $lok_allow --pidfile=$pidfile) >/dev/null & disown\"";

// Remove stale lock file (just in case)
if (file_exists("$lockfile"))
Expand Down