Skip to content

Handle empty profile responses #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
doej13367 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Handle empty profile responses #408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions Commands/AltChecker.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
namespace Coflnet.Sky.Commands.MC;
public class AltChecker
{
private const string StatsBaseUrl = "https://sky.shiiiyu.moe";

/// <summary>
/// Returns 0-100 probability of the player being an alt
/// </summary>
Expand All @@ -16,14 +18,29 @@ public class AltChecker
public async Task<int> AltLevel(string uuid)
{
var client = new RestClient();
var request = new RestRequest($"https://sky.shiiyu.moe/api/v2/coins/{uuid}", Method.Get);
var request = new RestRequest($"{StatsBaseUrl}/api/v2/coins/{uuid}", Method.Get);
var response = await client.ExecuteGetAsync(request);
if(response.Content.Contains("no SkyBlock profile"))
if (string.IsNullOrWhiteSpace(response.Content))
return -1;

if (response.Content.Contains("no SkyBlock profile", StringComparison.OrdinalIgnoreCase))
{
await client.ExecuteGetAsync(new RestRequest($"https://sky.shiiyu.moe/stats/{uuid}")); // request profile loading
await client.ExecuteGetAsync(new RestRequest($"{StatsBaseUrl}/stats/{uuid}")); // request profile loading
return -1;
}
var result = JsonConvert.DeserializeObject<Response>(response.Content);
Response result;
try
{
result = JsonConvert.DeserializeObject<Response>(response.Content);
}
catch (JsonException)
{
return -1;
}

if (result?.profiles == null || result.profiles.Count == 0)
return -1;

var maxPurse = result.profiles.Values.Max(p => p.purse);
return (int)Math.Max((20_000_000 - maxPurse) / 1_000_000 * 5, 0);
}
Expand Down
4 changes: 2 additions & 2 deletions Commands/Flipping/ProfileOpenCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ await socket.TryAsyncTimes(async () =>
span.SetTag("name", name);
socket.ExecuteCommand($"/pv {name}");
socket.Dialog(db => db.MsgLine($"Opened profile for §6{name}\n{McColorCodes.RESET}If nothing opens you can click this to put the name in chat", "suggest:/pv " + name, "Click to put the name in chat")
.LineBreak().MsgLine("Or open on skycrypt", "https://sky.shiiyu.moe/stats/" + name));
.LineBreak().MsgLine("Or open on skycrypt", "https://sky.shiiiyu.moe/stats/" + name));
}, "opening player profile");
}
}
}