fix: remove 8 unsound reductions, fix 8 buggy rules (#1006)#1052
Open
fix: remove 8 unsound reductions, fix 8 buggy rules (#1006)#1052
Conversation
…ment and Partition to ShortestWeightConstrainedPath. Also, delete related files for ExactCoverBy3Sets to MinimumWeightSolutionToLinearEquations and HamiltonianPath to ConsecutiveOnesSubmatrix. Update overhead calculations in various reduction implementations to reflect changes in problem structure.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1052 +/- ##
==========================================
- Coverage 97.94% 97.92% -0.03%
==========================================
Files 979 963 -16
Lines 100890 99708 -1182
==========================================
- Hits 98816 97635 -1181
+ Misses 2074 2073 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- sat_circuitsat: account for extra assignments/variables from unused SAT vars - sat_coloring: OR-gadget adds 11 edges (not 10), plus base triangle constant - circuit_spinglass: 4× spin and 6× interaction multipliers for gate arity Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Overhead expressions describe scaling (O(·)), not exact sizes. Revert constant-factor adjustments and keep only the two genuinely wrong asymptotic formulas: - CircuitSAT → SpinGlass: O(A) → O(A·V) (gate arity scales with variables) - SpinGlass → MaxCut edges: O(m) → O(m+n) (ancilla edges are O(n)) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This was referenced Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1006 — 16 buggy reduction rules identified by systematic NO-instance testing.
Remove 8 unsound reductions
Their
reduce_to()constructions are mathematically incorrect (target feasibility does not imply source feasibility). Problem models are retained; only the reduction edges are removed.Fix SAT → CircuitSAT panic
Handle variables that don't appear in any clause by adding identity assignments, preventing
unwrap()panic.Fix 2 overhead formulas (asymptotic errors)
O(A)→O(A·V)— gate arity scales with number of variables per assignmentO(m)→O(m+n)— ancilla edges contribute anO(n)termFix 3 extraction bugs
evaluate(), ignore paddingnum_interactions + num_spins)map_config_back_via_centersinstead of buggy weighted gadget unapplyTest plan
cargo test— 5152 tests pass, 0 failurescargo clippy— cleanmake paper— Typst paper compilestest_sat_to_circuitsat_unused_variables🤖 Generated with Claude Code