Skip to content

Paper review session 1-5: entries 1-50#1051

Open
isPANN wants to merge 9 commits intomainfrom
paper-review-session5
Open

Paper review session 1-5: entries 1-50#1051
isPANN wants to merge 9 commits intomainfrom
paper-review-session5

Conversation

@isPANN
Copy link
Copy Markdown
Collaborator

@isPANN isPANN commented Apr 14, 2026

Summary

  • MinimumMaximalMatching: add @xiao2014 citation and O*(1.3160^n) complexity for edge dominating set equivalence
  • PartitionIntoPathsOfLength2: upgrade canonical example from trivial 6-vertex to 9-vertex 3×3 grid (12 edges, 10 distinct valid groupings); add figure, pred commands, fixture integration
  • MinimumSumMulticenter: replace prose citations with @karivhakimi1979, @cohenaddad2022
  • MinMaxMulticenter: replace prose citations with @karivhakimi1979, @hochbaumshmoys1985, @hsunemhauser1979; add per-vertex distance enumeration
  • MultipleCopyFileAllocation: upgrade degenerate canonical example (all vertices host copies) to path P₆ with varied usage/storage showing storage-vs-access tradeoff; enrich background with CDN, database replication, UFL connection

Test plan

  • cargo test — all 138 tests pass
  • typst compile — paper builds cleanly, no warnings
  • Visual check of rendered PDF for all modified entries
  • Fixture regeneration via export_examples

🤖 Generated with Claude Code

isPANN and others added 5 commits April 14, 2026 11:57
The warning falsely reported 4 missing rules because .get() only sees
state accumulated before the current location. Rules defined after the
check were invisible. Using .final() sees all rules in the document.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…SetCovering)

- MinimumMaximalMatching: add @xiao2014 citation, O*(1.3160^n) complexity
- PartitionIntoPathsOfLength2: upgrade canonical example from trivial
  6-vertex (two disjoint paths) to 9-vertex 3×3 grid with 12 edges and
  10 distinct valid groupings; add figure, pred commands, fixture
- MinimumSumMulticenter: replace prose citations with @karivhakimi1979,
  @cohenaddad2022
- MinMaxMulticenter: replace prose citations with @karivhakimi1979,
  @hochbaumshmoys1985, @hsunemhauser1979; add per-vertex distances
- MultipleCopyFileAllocation: upgrade degenerate canonical example
  (all vertices host copies) to path P_6 with varied usage/storage
  showing storage-vs-access tradeoff; enrich background with CDN,
  database replication, UFL connection

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.94%. Comparing base (e38b1b5) to head (c6f0345).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1051   +/-   ##
=======================================
  Coverage   97.94%   97.94%           
=======================================
  Files         979      979           
  Lines      100890   100893    +3     
=======================================
+ Hits        98816    98819    +3     
  Misses       2074     2074           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Closes #1050 — users can now refer to the decision vertex cover problem
as "VC", "VertexCover", or "DMVC" (legacy). The internal registered name
remains DecisionMinimumVertexCover to avoid breaking the proc macro name
extraction in #[reduction].

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@isPANN isPANN changed the title Paper review session 5: entries 41-50 Paper review session 1-5: entries 1-50 Apr 14, 2026
isPANN and others added 3 commits April 14, 2026 17:21
Move trailing punctuation (periods, commas) from outside display math
closing `$` to inside the formula content, e.g. `$.\n` → content line
gets `.` appended and closing becomes `$\n`. Affects 100 instances
across both multi-line and single-line display equations.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…and reduction rules

This new skill allows users to review the Typst paper for quality issues, evaluating 10 entries per session and generating structured reports on mechanical and critical issues. The skill includes detailed checklists for both problem definitions and reduction rules, ensuring thorough evaluations without modifying any files.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant