Fixed button group global settings#2812
Open
girishpanchal30 wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes the global defaults panel for the Button Group block where the typography "Appearance" and "Letter Case" controls were wired to the wrong attributes (fontVariant/fontStyle), preventing those settings from being saved/rendered correctly. The new mapping (fontStyle for appearance, textTransform for letter case) matches the block's own inspector (src/blocks/blocks/button-group/group/inspector.js:441-451) and the front-end CSS output (edit.js:110-111).
Changes:
- Map
appearance↔fontStyleinstead offontVariantin both read and write ofcomponentsValue/onChange. - Map
letterCase↔textTransforminstead offontStyle.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Bundle Size Diff
|
Contributor
|
Plugin build for 8099406 is ready 🛎️!
|
Contributor
E2E TestsPlaywright Test Status: Performance ResultsserverResponse: {"q25":346,"q50":349.95,"q75":376.9,"cnt":10}, firstPaint: {"q25":363.2,"q50":425.2,"q75":466.4,"cnt":10}, domContentLoaded: {"q25":1398.8,"q50":1429.4,"q75":1448.4,"cnt":10}, loaded: {"q25":1399.4,"q50":1429.8,"q75":1448.7,"cnt":10}, firstContentfulPaint: {"q25":2977,"q50":2999.65,"q75":3005,"cnt":10}, firstBlock: {"q25":6136.7,"q50":6173.55,"q75":6196.1,"cnt":10}, type: {"q25":12.23,"q50":12.44,"q75":12.48,"cnt":10}, typeWithoutInspector: {"q25":11.04,"q50":11.24,"q75":11.33,"cnt":10}, typeWithTopToolbar: {"q25":14.64,"q50":15.92,"q75":17.09,"cnt":10}, typeContainer: {"q25":6.91,"q50":7.11,"q75":8.13,"cnt":10}, focus: {"q25":49.97,"q50":51.91,"q75":54.19,"cnt":10}, inserterOpen: {"q25":16.26,"q50":17.12,"q75":18.28,"cnt":10}, inserterSearch: {"q25":5.8,"q50":5.96,"q75":6.11,"cnt":10}, inserterHover: {"q25":2.95,"q50":3,"q75":3.15,"cnt":20}, loadPatterns: {"q25":973.7,"q50":1009.76,"q75":1044.28,"cnt":10}, listViewOpen: {"q25":77.25,"q50":80.91,"q75":90.81,"cnt":10} |
Soare-Robert-Daniel
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2267
Summary
Fixed the mapping of the font-related attributes.
Checklist before the final review