Skip to content

Fixed button group global settings#2812

Open
girishpanchal30 wants to merge 1 commit into
developmentfrom
bugfix/2267
Open

Fixed button group global settings#2812
girishpanchal30 wants to merge 1 commit into
developmentfrom
bugfix/2267

Conversation

@girishpanchal30
Copy link
Copy Markdown
Contributor

Closes #2267

Summary

Fixed the mapping of the font-related attributes.

Checklist before the final review

  • Included E2E or unit tests for the changes in this PR.
  • Visual elements are not affected by independent changes.
  • It is at least compatible with the minimum WordPress version.
  • It loads additional script in frontend only if it is required.
  • Does not impact the Core Web Vitals.
  • In case of deprecation, old blocks are safely migrated.
  • It is usable in Widgets and FSE.
  • Copy/Paste is working if the attributes are modified.
  • PR is following the best practices

@girishpanchal30 girishpanchal30 requested a review from Copilot May 19, 2026 12:10
@girishpanchal30 girishpanchal30 added the pr-checklist-skip Allow this Pull Request to skip checklist. label May 19, 2026
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label May 19, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the global defaults panel for the Button Group block where the typography "Appearance" and "Letter Case" controls were wired to the wrong attributes (fontVariant/fontStyle), preventing those settings from being saved/rendered correctly. The new mapping (fontStyle for appearance, textTransform for letter case) matches the block's own inspector (src/blocks/blocks/button-group/group/inspector.js:441-451) and the front-end CSS output (edit.js:110-111).

Changes:

  • Map appearancefontStyle instead of fontVariant in both read and write of componentsValue/onChange.
  • Map letterCasetextTransform instead of fontStyle.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@pirate-bot
Copy link
Copy Markdown
Contributor

Bundle Size Diff

Package Old Size New Size Diff
Animations 276.77 KB 276.77 KB 0 B (0.00%)
Blocks 1.55 MB 1.55 MB 4 B (0.00%)
CSS 105.9 KB 105.9 KB 0 B (0.00%)
Dashboard 204.08 KB 204.08 KB 0 B (0.00%)
Onboarding 165.94 KB 165.94 KB 0 B (0.00%)
Export Import 102.86 KB 102.86 KB 0 B (0.00%)
Pro 412.66 KB 412.66 KB 0 B (0.00%)

@pirate-bot
Copy link
Copy Markdown
Contributor

Plugin build for 8099406 is ready 🛎️!

@pirate-bot
Copy link
Copy Markdown
Contributor

E2E Tests

Playwright Test Status:

Performance Results serverResponse: {"q25":346,"q50":349.95,"q75":376.9,"cnt":10}, firstPaint: {"q25":363.2,"q50":425.2,"q75":466.4,"cnt":10}, domContentLoaded: {"q25":1398.8,"q50":1429.4,"q75":1448.4,"cnt":10}, loaded: {"q25":1399.4,"q50":1429.8,"q75":1448.7,"cnt":10}, firstContentfulPaint: {"q25":2977,"q50":2999.65,"q75":3005,"cnt":10}, firstBlock: {"q25":6136.7,"q50":6173.55,"q75":6196.1,"cnt":10}, type: {"q25":12.23,"q50":12.44,"q75":12.48,"cnt":10}, typeWithoutInspector: {"q25":11.04,"q50":11.24,"q75":11.33,"cnt":10}, typeWithTopToolbar: {"q25":14.64,"q50":15.92,"q75":17.09,"cnt":10}, typeContainer: {"q25":6.91,"q50":7.11,"q75":8.13,"cnt":10}, focus: {"q25":49.97,"q50":51.91,"q75":54.19,"cnt":10}, inserterOpen: {"q25":16.26,"q50":17.12,"q75":18.28,"cnt":10}, inserterSearch: {"q25":5.8,"q50":5.96,"q75":6.11,"cnt":10}, inserterHover: {"q25":2.95,"q50":3,"q75":3.15,"cnt":20}, loadPatterns: {"q25":973.7,"q50":1009.76,"q75":1044.28,"cnt":10}, listViewOpen: {"q25":77.25,"q50":80.91,"q75":90.81,"cnt":10}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Global options]Button Group block - Appearance, Letter case, Line height options not working

4 participants