London | 26-SDC-Mar | Ebrahim Beiati-Asl | Sprint 2 | Chat App frontend and backend#75
Open
ebrahimbeiati wants to merge 22 commits into
Open
London | 26-SDC-Mar | Ebrahim Beiati-Asl | Sprint 2 | Chat App frontend and backend#75ebrahimbeiati wants to merge 22 commits into
ebrahimbeiati wants to merge 22 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
ebrahimbeiati
changed the title
This comment has been minimized.
This comment has been minimized.
ebrahimbeiati
changed the title
This comment has been minimized.
This comment has been minimized.
ebrahimbeiati
changed the title
This comment has been minimized.
This comment has been minimized.
ebrahimbeiati
added
the
Needs Review
ebrahimbeiati
changed the title
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
ebrahimbeiati
changed the title
This comment has been minimized.
This comment has been minimized.
ebrahimbeiati
changed the title
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
ebrahimbeiati
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
ebrahimbeiati
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
ebrahimbeiati
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
ebrahimbeiati
added
Needs Review
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
ebrahimbeiati
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
ebrahimbeiati
added
the
Needs Review
cjyuan
reviewed
May 24, 2026
There was a problem hiding this comment.
Code works on normal circumstances. My comments are mainly surrounding handling of
errors and unusual user input.
The README has this requirement:
It must also support at least one additional feature.
Can you describe the additional features you have implemented?
Comment on lines
+33
to
+38
| timeStamp: new Date().toLocaleTimeString("en-US", { | ||
| hour: "numeric", | ||
| minute: "2-digit", | ||
| hour12: true, | ||
| }), | ||
| }; |
There was a problem hiding this comment.
Can you describe the pros and cons of creating the message timestamp
- on the user's machine
- on the server
?
In addition, how does this timestamp format affect users living in different time zones?
| app.post("/messages", (req, res) => { | ||
| const message = req.body; | ||
| messages.push(message); | ||
| res.status(201).json(message); |
There was a problem hiding this comment.
What's the reason to embed the received user message in the response?
Note: Normally we should also validate the message, but in this exercise let's assume the message format is always valid. That is, let's assume the received message is always sent by the code in script.js.
Comment on lines
+40
to
+46
| await fetch(`${BACKEND_URL}/messages`, { | ||
| method: "POST", | ||
| headers: { | ||
| "Content-Type": "application/json", | ||
| }, | ||
| body: JSON.stringify(newMessage), | ||
| }); |
Comment on lines
+11
to
+12
| const response = await fetch(`${BACKEND_URL}/messages`); | ||
| const messages = await response.json(); |
cjyuan
added
Reviewed
ebrahimbeiati
added
the
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Backend
https://xwc7hmpmk5kvt9ktptcvuuke.hosting.codeyourfuture.io
Frontend
https://uretqju43s9008b1nyjk586m.hosting.codeyourfuture.io