Skip to content

fix: password inputs not saving #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yuri-kiss wants to merge 1 commit into
base: develop
Choose a base branch
from
+12 −2
Open

fix: password inputs not saving #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/addons/settings-store.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,17 @@ class SettingsStore extends EventTargetShim {
if (typeof value !== 'number') {
throw new Error('Setting value is invalid.');
}
} else if (settingObject.type === 'string' || settingObject.type === 'long_string' || settingObject.type === 'untranslated') {
} else if (
settingObject.type === 'string' ||
settingObject.type === 'long_string' ||
settingObject.type === 'untranslated'
) {
// always valid
} else if (
settingObject.type === 'password' ||
settingObject.type === 'long_password'
) {
value = String(value);
// always valid
} else if (settingObject.type === 'color') {
if (typeof value !== 'string') {
Expand All @@ -309,7 +319,7 @@ class SettingsStore extends EventTargetShim {
throw new Error('Setting value is invalid.');
}
} else {
throw new Error('Setting object is of unknown type');
throw new Error(`Setting object is of unknown type: ${settingObject.type}`);
}
storage[settingId] = value;
}
Expand Down
Loading