Fix Lab 7 feedback: enforce PLAYER role default, proper 404s, admin-only role assignment, expanded TDD

[Copilot]

Addresses graded feedback (Lab 7) identifying partial compliance in controller business rules, HTTP status codes, and TDD coverage. The critical finding was missing @Service (already present in current HEAD); remaining items required actual code changes.

Changes

User role enforcement

• Added role field to UserEntity (default "PLAYER") and UserRoleModel; updated UserMapper to map it bidirectionally
• UserService.createUser now explicitly sets role = "PLAYER" regardless of request payload

Admin-only role assignment

• Added assignRole(Long targetUserId, String newRole, Long adminUserId) to IUserService and UserService
  • Validates newRole against allowlist: PLAYER, ADMIN, ORGANIZER, REFEREE
  • Checks admin.getRole() directly on UserEntity — no entity→model→entity roundtrip
• Exposed as PUT /api/users/{id}/role?role=X&adminUserId=Y in UserController

Proper HTTP status codes

• Created NotFoundException in new exception package
• Services throw NotFoundException for all not-found cases; generic RuntimeException remains for validation/business-rule failures
• Controllers now catch both separately: NotFoundException → 404, RuntimeException → 400/401

} catch (NotFoundException e) {
    return ResponseEntity.status(HttpStatus.NOT_FOUND).body(e.getMessage());
} catch (RuntimeException e) {
    return ResponseEntity.status(HttpStatus.BAD_REQUEST).body(e.getMessage());
}

Applies to UserController (updateUser, deactivateUser) and all TournamentController operations.

TDD coverage (59 → 80 tests)

• authenticate: 6 new tests covering all failure paths (null/blank email, null password, user not found, wrong password, inactive account)
• createUser: asserts PLAYER role is set by default
• NotFoundException propagation: covered for all service methods that do lookups
• assignRole: admin not found, non-admin caller, target user not found, invalid role value

[sonarqubecloud]

Quality Gate failed

Failed conditions
B Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE