🔧 chore(gui,paint): css var adjustments#238
Open
SimonShiki wants to merge 2 commits into
Open
Conversation
Signed-off-by: SimonShiki <sinangentoo@gmail.com>
SimonShiki
added
gui
Deploying clipcc-preview with
|
| Latest commit: |
0896cf1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://71969b3a.clipcc-preview.pages.dev |
| Branch Preview URL: | https://fix-css-var.clipcc-preview.pages.dev |
There was a problem hiding this comment.
Pull request overview
This PR adjusts how the GUI and Paint packages handle CSS-variable stylesheets, aiming to avoid bundling those variable definitions in library builds and to align a shared sizing token between the two packages.
Changes:
- Export
src/css/*.cssintodist/styles/during library builds (GUI + Paint) viacopy-webpack-plugin. - Move CSS variable imports out of component CSS modules and into the playground entry CSS files.
- Align
--clipcc-library-header-heightin Paint to match GUI.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Adds copy-webpack-plugin for paint; lockfile metadata now flags @ungap/structured-clone@1.3.0 as deprecated (CWE note). |
| packages/paint/webpack.config.js | Copies Paint src/css/*.css to dist/styles/ for library consumers. |
| packages/paint/src/playground/playground.css | Imports Paint colors.css/units.css at the playground entry level. |
| packages/paint/src/css/units.css | Updates --clipcc-library-header-height to 3.125rem (matching GUI). |
| packages/paint/src/components/paint-editor/paint-editor.css | Removes imports of CSS-variable files from component CSS. |
| packages/paint/package.json | Adds copy-webpack-plugin dev dependency. |
| packages/gui/webpack.config.js | Copies GUI src/css/*.css to dist/styles/ for library consumers. |
| packages/gui/src/playground/index.css | Imports GUI colors.css/units.css/z-index.css at the playground entry level; trims trailing whitespace. |
| packages/gui/src/components/gui/gui.css | Removes imports of CSS-variable files from the main GUI CSS module. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
1
to
3
| .page-wrapper { | ||
| height: 100%; | ||
| } |
Comment on lines
+1
to
+4
| @import "../css/colors.css"; | ||
| @import "../css/units.css"; | ||
| @import "../css/z-index.css"; | ||
|
|
Comment on lines
+293
to
301
| // Export necessary CSS files for external use. | ||
| new CopyWebpackPlugin({ | ||
| patterns: [ | ||
| { | ||
| from: 'src/css/*.css', | ||
| to: 'styles/[name][ext]' | ||
| } | ||
| ] | ||
| }) |
Comment on lines
+110
to
+120
| plugins: base.plugins.concat([ | ||
| // Export necessary CSS files for external use. | ||
| new CopyWebpackPlugin({ | ||
| patterns: [ | ||
| { | ||
| from: 'src/css/*.css', | ||
| to: 'styles/[name][ext]' | ||
| } | ||
| ] | ||
| }) | ||
| ]) |
Comment on lines
3388
to
+3390
| '@ungap/structured-clone@1.3.0': | ||
| resolution: {integrity: sha512-WmoN8qaIAo7WTYWbAZuG8PYEhn5fkz7dZrqTBZ7dtt//lL2Gwms1IcnQ5yHqjDfX8Ft5j4YzDM23f87zBfDe9g==} | ||
| deprecated: Potential CWE-502 - Update to 1.3.1 or higher |
Signed-off-by: SimonShiki <sinangentoo@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adjust how gui/paint treat css variable stylesheets.
Proposed Changes
Test Coverage
None
Additional Context
None