Skip to content

patch: handle CFVariable in CI#45

Merged
ErikKusch merged 1 commit into
masterfrom
37-update-function-argument-table-in-ci-upon-release
Jun 2, 2026
Merged

patch: handle CFVariable in CI#45
ErikKusch merged 1 commit into
masterfrom
37-update-function-argument-table-in-ci-upon-release

Conversation

@thisistaimur
Copy link
Copy Markdown
Collaborator

@thisistaimur thisistaimur commented Jun 2, 2026

I patched .github/scripts/update_argument_usage.R to handle CFVariable the same way it already handled extent: it now has a canonical override entry, so CI won’t stop on that shared-argument conflict. I also improved the ambiguity error so the next time a new shared argument has conflicting .Rd text, the failure tells you exactly to add an entry to argument_description_overrides.

If the CI pipeline below passes, then feel free to merge!

@thisistaimur thisistaimur requested a review from ErikKusch June 2, 2026 11:02
@ErikKusch ErikKusch merged commit 43570b7 into master Jun 2, 2026
4 of 5 checks passed
@ErikKusch
Copy link
Copy Markdown
Collaborator

Perfect! Thanks, man!

@thisistaimur thisistaimur deleted the 37-update-function-argument-table-in-ci-upon-release branch June 2, 2026 11:04
@thisistaimur thisistaimur restored the 37-update-function-argument-table-in-ci-upon-release branch June 2, 2026 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants