Simple partitioned aggregation#298
Merged
Merged
Conversation
serprex
force-pushed
the
simple-partitioned-aggregate
branch
4 times, most recently
from
f5d93af to
4691d40
Compare
theory
requested changes
Jun 29, 2026
theory
left a comment
theory
left a comment
Collaborator
There was a problem hiding this comment.
This is SPLENDID, thank you! Just a few things to tweak and some questions. Documentation to explain how this works and when it doesn't work could be a different PR, as long as it happens. I want it to be clear to people why some aggregate across partitions will or won't map/reduce.
serprex
force-pushed
the
simple-partitioned-aggregate
branch
2 times, most recently
from
6780f7c to
1b5d167
Compare
serprex
force-pushed
the
simple-partitioned-aggregate
branch
from
1b5d167 to
9f6beb8
Compare
theory
requested changes
Jun 30, 2026
serprex
force-pushed
the
simple-partitioned-aggregate
branch
from
9f6beb8 to
6c5c48e
Compare
serprex
force-pushed
the
simple-partitioned-aggregate
branch
from
6c5c48e to
ad34590
Compare
theory
approved these changes
Jun 30, 2026
serprex
force-pushed
the
simple-partitioned-aggregate
branch
5 times, most recently
from
6b942de to
278f191
Compare
enables aggregate pushdown of partitioned table with some partitions on ClickHouse only supports simple aggregates for now
serprex
force-pushed
the
simple-partitioned-aggregate
branch
from
278f191 to
74c725e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements support for pushing down some partial aggregates. This opens up having partitioned tables with mix of postgres/clickhouse partitions. Useful for example where old data is dropped from postgres, but kept in ClickHouse