Skip to content

Fix reply memory leak in retryable command retry loop #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
groeneai wants to merge 1 commit into
base: ClickHouse/2.3.0
Choose a base branch
from
Open

Fix reply memory leak in retryable command retry loop #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/libmongoc/src/mongoc/mongoc-cursor.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -745,6 +745,11 @@ _retryable_cursor_commmand_select_retry_server(void *user_data,

mongoc_cursor_t *const cursor = context->cursor;

/* `reply` still owns the previous attempt's contents, and stream_for_reads
* overwrites it as an out-param on server-selection failure without freeing
* it first. Reset it here so that allocation is not leaked. */
bson_destroy(reply);
bson_init(reply);

*context->server_stream = mongoc_cluster_stream_for_reads(&cursor->client->cluster,
context->ss_log_context,
Expand Down