chore: bump pinned test AWS CLI version to 2.36.19 - #243
Open
circleci-app[bot] wants to merge 1 commit into
Open
chore: bump pinned test AWS CLI version to 2.36.19#243circleci-app[bot] wants to merge 1 commit into
circleci-app[bot] wants to merge 1 commit into
Conversation
The orb installs "latest" by default via the AWS-hosted installer, but the `test-install-version` and `test-install-override-version` integration tests pin a specific version to prove the version pin works. That fixture was pinned at 2.15.57, which is far behind the current AWS CLI v2 release. Refresh the pinned test fixture to 2.36.19 (the highest version available across the linux/macOS installers and the Chocolatey `awscli` package used by the Windows executor). No orb behavior change; only the version referenced by the test fixture moves. The `integration-test-skip-install-matched-version` test's 2.1.21 pin is intentionally kept — it verifies override to an older-than-preinstalled version and should not be bumped. AI-Generated: true
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The orb installs the AWS CLI's
latestrelease by default (resolved dynamically at runtime via the AWSaws/aws-cliGitHub tags API), so there is no version pin in the install commands themselves to bump. However,.circleci/test-deploy.ymlpins a specific version in thetest-install-versionandtest-install-override-versionintegration tests to prove version pinning works end-to-end. That fixture was2.15.57, which is far behind current AWS CLI v2 releases.Version bump:
2.15.57→2.36.19(test fixture only).2.15.57(2024-05, quite stale)2.36.19(current AWS CLI v2 release available across every install path the tests exercise)Why 2.36.19 and not 2.36.20
2.36.20is the very latest GitHub tag foraws/aws-cli, but the Chocolateyawsclipackage (used by thewindowsexecutor viachoco install -y awscli --version=…) had only published up to2.36.19at the time of writing. Picking2.36.19keeps every installer path (Linux x86_64 zip, Linux aarch64 zip, macOS pkg, Chocolatey) on the same, currently-available version. Verified all four artifacts returnHTTP 200.Breaking changes in the range?
The 2.15.57 → 2.36.19 range is enormous, but almost every entry is an
api-change:for an individual AWS service — none of which the orb's tests use. Reviewing everyfeature:,breaking,removed, anddeprecatedentry across the range:aws updatecommand,aws logincommand,aws configure agent-toolkit,--no-overwritefors3 cp/mv/sync,--output off, universal macOS binary, web-browser help,feature:s3 downloadcontent-range validation.feature:Output: structured error output ... The new enhanced format is the default. Set cli_error_format=legacy to preserve the original error format.This changes the default error format from legacy toenhanced. The orb's tests only run success-path commands (aws --version,aws sts get-caller-identity,aws configure get …,aws ecr get-login-password) and do not parse error output, so this default change does not affect them. No test workaround was needed and no flag was added to restore the old default.api-change:clients: The … client has been removedentries (iotevents, panorama, simspaceweaver, qldb, robomaker, elastictranscoder, opsworks, sms, evidently, iotanalytics). The orb does not use any of these.What was NOT changed
integration-test-skip-install-matched-versiontest still pins2.1.21on thearmexecutor. That test intentionally uses a very old version to verify thatoverride_installed: truecan install a version older than what is preinstalled. Bumping it would change what the test is actually asserting, so it is left alone.CI
Cannot pre-run this pipeline from the scheduled task — CircleCI will run against the branch when the PR opens and results will appear on the PR's checks. If any job fails for a reason related to the version bump (rather than infra flake), that will need to be diagnosed before merge rather than worked around.
View this task in the CircleCI web app →