You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
minimal:
Established practice for a production slice on a thin SDK decode adapter is to preserve the existing parser and serde bridge, avoid expanding API surface, and pin Lua-facing behavior with black-box regression tests. From the provided diff, the PR follows the smallest coherent path: it adds focused real-Lua coverage for toml.decode invalid-input error text, representative scalar/table/array conversion, Lua sequence indexing, empty-document behavior, and continued absence of toml.encode, without adding unproven parser, conversion, or encode scope.
structural:
Established practice for this problem class is a thin SDK decode adapter over the canonical parser and existing serialization bridge, with the Lua boundary covered by black-box contract tests; this PR preserves that structure by adding only focused sdk_toml tests for toml.decode, continuing to rely on the existing toml crate and LuaSerdeExt, validating fail-closed toml.decode invalid-toml: behavior and Lua sequence semantics, and keeping toml.encode absent, so module boundaries and source-of-truth remain clean.
delete:
Established practice for SDK primitives is to avoid duplicate surface, expose only the accepted narrow operation, delegate parsing to a mature deterministic library, and lock the public boundary with black-box tests; under the delete angle, the relevant change is that PR #253 adds only regression coverage for the already-settled toml.decode surface, continues to prove toml.encode is absent, and introduces no parser, converter, or abstraction to delete, so there is no delete-specific blocker.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-devloop implementation PR for issue #252