github-devloop implementation for #245

[loning]

github-devloop implementation PR for issue #245

[loning]

github-devloop PR child open

[loning]

github-devloop PR is ready for review

[loning]

github-devloop PR is ready for review

[codecov]

Codecov Report

❌ Patch coverage is 87.17949% with 35 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
crates/fkst-framework/src/supervise/mod.rs	0.00%	23 Missing ⚠️
...tes/fkst-framework/src/supervise/delivery_store.rs	92.94%	11 Missing ⚠️
...es/fkst-framework/src/supervise/delivery_router.rs	95.83%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

[loning]

github-devloop PR review decision: approve
Three-angle verdicts: minimal=approve structural=approve delete=approve

minimal:
Established durable-queue practice is that durable work is addressed by queue or consumer group, while concrete consumer identity is ephemeral; unacked or stale-owner deliveries must redeliver to current membership or surface via DLQ, not remain silently pending. From the minimal angle, this diff follows the smallest coherent path for #245: it derives unambiguous current reliable subscribers with single_reliable_subscribers_by_queue, rebinds stale DeliveryRecord.dept entries in rebind_deliveries_to_current_subscribers, preserves lease timing while invalidating the old generation for in-flight work, wires the repair at supervisor startup, and adds focused ready, in-flight, router, and dispatch coverage. Scope is narrow enough to advance; broader multi-subscriber routing or no-successor DLQ policy would need either a stated requirement amendment or evidence that single-subscriber rebind cannot cover the observed consumer-swap failure.

structural:
Established durable-queue practice is that the queue engine owns delivery state, queue/subscription identity is the durable source of truth, and consumer membership is ephemeral lease ownership; this diff follows that structure by deriving the current single reliable subscriber from DeliveryRouter, rebinding stale DeliveryStore records and secondary indexes inside the store transaction, preserving lease-generation invalidation for old in-flight acks, and emitting journal/log facts at the supervise boundary, so the module boundaries and data-flow contract are clean enough for merge-ready under the stated scope.

delete:
Established durable-queue practice is queue-addressed work with leases/redelivery and DLQ, not durable work permanently owned by an ephemeral consumer identity; from the delete angle this diff is acceptable because rebind_deliveries_to_current_subscribers and single_reliable_subscribers_by_queue are internal repair/collapse mechanisms that remove stale dept ownership and reuse the existing ready/lease indexes rather than adding a new external delivery surface, while the new delivery_rebound journal fact is only diagnostic evidence for that collapse.

⟦AI:FKST⟧

[loning]

github-devloop is merging PR #246

[loning]

github-devloop merged PR #246