ENH/REF: split up plotting + add Bokeh plotting#133
Draft
ken-lauer wants to merge 23 commits into
Draft
Conversation
bb3c87e to
66eb4f6
Compare
47aa1b2 to
2fd8df0
Compare
Contributor
Author
|
This is getting closer and probably should have some eyes on it. Take a look at |
Owner
Contributor
Author
|
Using There are some workarounds, but they're not so pretty (like putting a |
Contributor
Author
|
This will need a very careful rebase/merge after #142 made it in 😢 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Overview
backend="mpl"orbackend="bokeh", similar to how we do it in PyTao."mpl", for back-compat and such. Users can configure this as theBEAMPHYSICS_PLOTenvironment variable ("bokeh"or"mpl"for nowAttribution
I did the initial prepare/plot split and the Bokeh marginal plot, then added Claude into the mix to tackle the remainder following the pattern. Many fixes on top of that, and also bringing in some PyTao notebook handling tools I wrote a while back.