Skip to content

Support dX dice shorthand - #346

Open
lyrae-versebound wants to merge 2 commits into
Chris3606:masterfrom
lyrae-versebound:lyrae/EXP-010-issue-337
Open

Support dX dice shorthand#346
lyrae-versebound wants to merge 2 commits into
Chris3606:masterfrom
lyrae-versebound:lyrae/EXP-010-issue-337

Conversation

@lyrae-versebound

Copy link
Copy Markdown

Summary

  • Accept dice shorthand such as dX by treating a leading d as an implicit single-die operand.
  • Preserve parser operand state so shorthand works correctly around closing parentheses and whitespace.
  • Add regression coverage for shorthand and the related parser transitions.

Validation

  • Focused tests: 19/19.
  • Neighboring parser tests: 22/22.
  • Complete GoRogue.UnitTests: 1326/1326 in Debug.
  • Complete GoRogue.UnitTests: 1326/1326 in Release.

Fixes #337

@lyrae-versebound
lyrae-versebound marked this pull request as ready for review August 14, 2026 22:58
@Chris3606

Copy link
Copy Markdown
Owner

Thanks! I'm on vacation at the moment but hopefully can get to looking at this in detail in a couple days.

@lyrae-versebound

Copy link
Copy Markdown
Author

Thanks! Just trying to give a little back to projects we’ve used and appreciated. No rush at all — take a look whenever you get a chance! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support "dx" instead of "ydx" for single dice in dice notation

2 participants