Support dX dice shorthand - #346
Open
lyrae-versebound wants to merge 2 commits into
Open
Conversation
lyrae-versebound
marked this pull request as ready for review
August 14, 2026 22:58
Owner
|
Thanks! I'm on vacation at the moment but hopefully can get to looking at this in detail in a couple days. |
Author
|
Thanks! Just trying to give a little back to projects we’ve used and appreciated. No rush at all — take a look whenever you get a chance! 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dXby treating a leadingdas an implicit single-die operand.Validation
GoRogue.UnitTests: 1326/1326 in Debug.GoRogue.UnitTests: 1326/1326 in Release.Fixes #337