Skip to content

refactor(reflect): rename review candidate to target#618

Open
Donmagelas wants to merge 1 commit into
CherryHQ:mainfrom
Donmagelas:codex/issue-532-reflect-candidates
Open

refactor(reflect): rename review candidate to target#618
Donmagelas wants to merge 1 commit into
CherryHQ:mainfrom
Donmagelas:codex/issue-532-reflect-candidates

Conversation

@Donmagelas

Copy link
Copy Markdown
Contributor

What

Rename the existing session-level Reflect review candidate type to reviewTarget.

Why

#532 introduces generated fact/skill candidates. Keeping the current session selection type named candidate makes the package ambiguous before the generated candidate types land.

How

  • Rename internal/reflect/candidates.go to review_targets.go.
  • Rename the internal session review type and helpers to reviewTarget / unreviewedTarget / sortReviewTargets.
  • Rename local loop variables and the trace attribute to review_target_count.
  • Add a compile-time test guard that listUnreviewed returns []reviewTarget.

Test Plan

  • mise exec -- go test -count=1 ./internal/reflect

Refs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant