Add RISEx venue integration - #2
Open
ignimbrite wants to merge 1 commit into
Open
Conversation
Adds RISEx (mainnet perps exchange) as a new benchmarkable venue, following the existing multi-venue pattern: Go spec.Definition + Python EIP-712 signing subprocess for order placement, WS confirmation, and cleanup. Live-verified against mainnet (10/10 place+WS-confirm+cancel+WS-cancel-confirm cycles), including catching and fixing two real signing bugs (header_flags/action-hash mismatch causing every order to fail signature verification, and a nonce-anchor caching race between the place and cleanup processes) that were only discoverable through live testing. Also documents a confirmed RISEx-side limitation with concurrent batch order submission. Includes frontend additions (real RISEx logo/brand color, chart color) and account-setup wiring (RISEX_PRIVATE_KEY / RISEX_ACCOUNT_ADDRESS / RISEX_SIGNER_PRIVATE_KEY, supporting setups where the main account's raw private key isn't available or exported, e.g. hardware wallets).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spec.Definition+ Python EIP-712 signing subprocess for order placement, WS confirmation, and cleanup.header_flags/action-hash mismatch that made every real order fail signature verification (SignerNotAuthorized).SystemExit,HTTPBatch: false) rather than faked: RISEx's strict sequentialnonce_anchormakes the usual concurrent-fanout workaround (used for Nado/Extended) unreliable — confirmed live (1 of 5 concurrent orders succeeded in one test). Matches edgeX's precedent for venues without a real batch endpoint.before_run/after_runsweep) that RISEx was missing — caught real leftover orders live during testing.build_payload_test.py/cancel_payload_test.py, including a signature-recovery regression test verified to actually catch the header_flags bug by reintroducing it.RISEX_PRIVATE_KEY/RISEX_ACCOUNT_ADDRESS(address-only alternative for hardware wallets or signers already registered via RISEx's website) /RISEX_SIGNER_PRIVATE_KEY.Test plan
gofmt,go build ./...,go vet ./...,go test ./...all cleanbuild_payload_test.py/cancel_payload_test.py(22 tests) pass, including offline signature-recovery checks