Open
Conversation
Pin elasticsearch-java to 8.18.0 (defer ES 9 migration) and testcontainers to 1.19.3 (defer TC 2.x migration). Drop now-BOM-managed version pins for junit-jupiter and jackson-core.
Rename spring-boot-starter-web to spring-boot-starter-webmvc (old name removed). Remove <executable>true</executable> from the Maven plugin (embedded launch scripts dropped; java -jar still works). Fix HttpConnectorConfig: TomcatServletWebServerFactory and ServletWebServerFactory moved to new packages; rename addAdditionalTomcatConnectors to addAdditionalConnectors.
springdoc 2.x is incompatible with Spring Framework 7. 3.0.3 is the first release tested against SB 4.0.5. Add spring-boot-starter-webmvc-test which Spring Boot 4 requires for @WebMvcTest and @AutoConfigureMockMvc to resolve (test slice module split).
Remove security.require-ssl (dropped in SB4) and spring.http.log-request-details (moved) from all property files.
Replace com.fasterxml.jackson.* with tools.jackson.* in non-ES code (InfoService, ArchiverService, AAChannelProcessor, ChannelProcessor, PopulateDBConfiguration). Use JsonMapper builder pattern for ObjectMapper construction. Catch JacksonException instead of JsonProcessingException. ElasticConfig and the three repositories retain Jackson 2 ObjectMapper because elasticsearch-java 8.x JacksonJsonpMapper requires Jackson 2; add comments marking these for migration when ES 9 lands. Update tests: fix AAChannelProcessorTest for Jackson 3 alphabetical field ordering; update ArchiverServiceTest for renamed exception type.
Spring Boot 4 moved @WebMvcTest and @AutoConfigureMockMvc from org.springframework.boot.test.autoconfigure.web.servlet.* to org.springframework.boot.webmvc.test.autoconfigure.* as part of the web module modularisation. Update 29 test files.
SB4's modular structure and JaCoCo instrumentation push container startup past the 30 s health-check interval, causing Testcontainers to time out before a second check can run. - compose.yml: add start_period: 60s so early failures don't burn retries - ITUtil: raise TC startup timeout from 60 s to 3 minutes
anderslindho
force-pushed
the
spring-boot-4
branch
from
0d45ca1 to
46228be
Compare
|
|
anderslindho
requested review from
domonkos-ess,
georgweiss,
imretoth-ess,
jacomago,
shroffk,
simon-ess and
tynanford
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.