Turbo Repo Migration#225
Conversation
This change is 90% file migrations with a conversion over to using pnpm. more work needs to be done before this can be merged into the mainline. Github actions needs to be modified to use turbo repo. Ideally we should split this out into smaller components and have the registry isolated correctly but this initial work needed to be done
|
Checks are expected to fail at this point. |
These examples are a good refernce for how to use turbo repo but will be added back manually later tailored to liftkit.
There was a problem hiding this comment.
I think we should extrapolate everything except the registry/ directory to do:
packages/liftkit/* -> apps/nextjs
Then from the registry/ folder:
packages/liftkit/registry/universal -> packages/universal
packages/liftkit/registry/nextjs -> packages/nextjs
This way all the app example templates can live in the apps/ directory and all of their component library directories and resources can live in the internal packages/ directories to be shared to their relevant template application or imported into the user's own application if they don't want to build off of the templates.
So now I would add in my svelte stuff like
packages/sveltekit for svelte components
apps/sveltekit for the actual sveltekit template application
so they're all managed independently and not sharing the same package.json files.
|
One thing will need to be rewritten in order for this to work. To be clear I do agree it needs to be broken up. packages/
- └── liftkit/
- ├── components/
- ├── utils/
- └── registry/
- ├── universal/
- └── nextjs/
+ ├── universal/ # from liftkit/registry/universal
+ ├── nextjs/ # from liftkit/registry/nextjs
+ └── sveltekit/ # future Svelte components example
apps/
- └── nextjs/
+ ├── nextjs/ # now includes main Liftkit app logic formerly in packages/liftkit/*
+ └── sveltekit/ # new template app for SvelteKit |
A few more things need to be done before this can be merged