Skip to content

Turbo Repo Migration#225

Draft
JeremiahSecrist wants to merge 7 commits into
mainfrom
turbo-repo
Draft

Turbo Repo Migration#225
JeremiahSecrist wants to merge 7 commits into
mainfrom
turbo-repo

Conversation

@JeremiahSecrist

Copy link
Copy Markdown
Collaborator

A few more things need to be done before this can be merged

  1. Github cicd needs to be modified to use turbo repo
  2. Certain portions need to be split up correctly.
  3. package drift needs to be checked against in monorepo style
  4. template portions need to be removed.
  5. turbo.json needs to be update as right now it is the default config.

JeremiahSecrist and others added 5 commits September 29, 2025 14:54
This change is 90% file migrations with a conversion over to using pnpm.
more work needs to be done before this can be merged into the mainline.
Github actions needs to be modified to use turbo repo.
Ideally we should split this out into smaller components and have the
registry isolated correctly but this initial work needed to be done
@JeremiahSecrist

Copy link
Copy Markdown
Collaborator Author

Checks are expected to fail at this point.

These examples are a good refernce for how to use turbo repo but will be
added back manually later tailored to liftkit.
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying liftkit with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0615553
Status:🚫  Build failed.

View logs

@JosefSaltz JosefSaltz left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should extrapolate everything except the registry/ directory to do:

packages/liftkit/* -> apps/nextjs

Then from the registry/ folder:

packages/liftkit/registry/universal -> packages/universal

packages/liftkit/registry/nextjs -> packages/nextjs

This way all the app example templates can live in the apps/ directory and all of their component library directories and resources can live in the internal packages/ directories to be shared to their relevant template application or imported into the user's own application if they don't want to build off of the templates.

So now I would add in my svelte stuff like

packages/sveltekit for svelte components

apps/sveltekit for the actual sveltekit template application

so they're all managed independently and not sharing the same package.json files.

@JeremiahSecrist

JeremiahSecrist commented Oct 9, 2025

Copy link
Copy Markdown
Collaborator Author

One thing will need to be rewritten in order for this to work.
At present the json generator is designed in such a fashion that it is hard-coded.

To be clear I do agree it needs to be broken up.
For visual clarity it would look something like below?

 packages/
- └── liftkit/
-     ├── components/
-     ├── utils/
-     └── registry/
-         ├── universal/
-         └── nextjs/
+ ├── universal/        # from liftkit/registry/universal
+ ├── nextjs/           # from liftkit/registry/nextjs
+ └── sveltekit/        # future Svelte components example

 apps/
- └── nextjs/
+ ├── nextjs/           # now includes main Liftkit app logic formerly in packages/liftkit/*
+ └── sveltekit/        # new template app for SvelteKit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants