chore: log missing payload in ExecutionPayloadEnvelopesByRoot#9435
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the ExecutionPayloadEnvelopesByRoot request handler to accept peerId and peerClient parameters and adds debug logging when a block root or envelope cannot be found. The review comments suggest making peerId and peerClient optional parameters to prevent compilation failures in existing unit tests and guarding the prettyPrintPeerId calls to avoid runtime TypeErrors if peerId is undefined.
Contributor
Performance Report✔️ no performance regression detected Full benchmark results
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #9435 +/- ##
=========================================
Coverage 52.56% 52.56%
=========================================
Files 848 848
Lines 60937 60937
Branches 4485 4485
=========================================
Hits 32031 32031
Misses 28844 28844
Partials 62 62 🚀 New features to boost your workflow:
|
nflaig
reviewed
Jun 1, 2026
nflaig
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In glamsterdam-devnet-4, Prysm was not able to fetch an envelope by root from our node (https://discord.com/channels/595666850260713488/1508479832596418692/1509536577217626183). When a peer requests a payload by root that we don't serve, the handler drops it silently — no way to tell why or which peer.
Description
Add
debuglogs (with peer, client, root) whenExecutionPayloadEnvelopesByRootserves nothing for a requested root, distinguishing the two cases:AI Assistance Disclosure