Skip to content

fix: dimensions from live YAML only (cherry-pick from main) #2229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Flotapponnier merged 1 commit into from
Sep 1, 2026
Merged

fix: dimensions from live YAML only (cherry-pick from main) #2229

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/lib/spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,12 @@ export function overlayEditorial(stored: Benchmark, spec: Spec): Benchmark {
// too so newly added dimension values (e.g. region opts added to
// an existing bench) surface immediately on the compare matrix
// and the bench page filters without waiting on the materialise
// worker to rewrite the snapshot.
dimensions: spec.dimensions ?? stored.dimensions,
// worker to rewrite the snapshot. No `?? stored` fallback: the
// live YAML is the source of truth, so a spec that declares NO
// dimensions must not inherit tabs from a snapshot written by a
// worker running a divergent branch (keyed-rpc-robinhood: main is
// Singapore-only while dev/worker carries the region dims).
dimensions: spec.dimensions,
// provider_notes is a YAML editorial declaration: drives the
// per-provider chip rendered next to the name in the ranking row.
// Overlay so newly added notes surface immediately without waiting
Expand Down
Loading