fee-compare: signed-carry review fixes + GMX subsquid schema repair - #2224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrections issues de la review du commit apple-to-apple (4de0f17), plus un bug de prod découvert au test.
Review fixes
fundingFees > 0.001droppait les crédits de funding (négatifs) — un wallet côté receveur perdait son crédit projeté sur dYdX/Paradex. Passage àMath.abs, idem pourfundingProjected.Math.max(0, fundingFeesUsdc)annulait les crédits de funding GMX réalisés. Supprimé, le signe est conservé.est > 0.01jetait les estimations créditrices. Passage àMath.abs.interest_rate(non signé, filtré > 0), ce qui créditait systématiquement les shorts avec le modèle signé. Bascule sur/v1/markets/summaryfunding_rate(signé).Prod bug (schema drift Subsquid GMX)
indexToken { symbol }n'existe plus surTradeAction— la requête échouait en validation GraphQL et le wallet GMX renvoyait silencieusement 0 trades en prod. Remplacé parmarketAddressmappé viaGMX_MARKETS.Tests (API locale, wallets réels)