fix: HL funding projection accuracy - #2216
Merged
Merged
Conversation
…uivFee uses HL rate not Gains rate
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugs fixed
1.
Math.max(0, cost)incomputeHlFundingThe cross-sim was ignoring funding received (negative cost). If your Gains positions would have received funding on HL, the projection was showing $0 instead of a negative number. This made HL look artificially expensive. Now the projection is signed (positive = paid, negative = received).
2. PONS in
coinsToFetchWhen building the list of coins to fetch HL funding history for, we were including Gains-exclusive coins (e.g. PONS) which don't exist on HL. This wasted an API call and a slot in the 6-coin cap, potentially missing actual HL-comparable coins.
3. 6-coin cap too restrictive
Raised to 20. A wallet trading 7+ distinct coins would miss funding history for the extra ones.
4. Position reconstruction includes non-HL coins
reconstructGainsPositionsnow only receives positions for HL-available coins, matching the fee accounting logic.5.
fundingProjectedflag not handling negative fundinghlFunding > 0.01→Math.abs(hlFunding) > 0.01Test result (before vs after)