Clipping polygon buffer migration#13623
Open
mzschwartz5 wants to merge 1 commit into
Open
Conversation
Contributor
|
Thank you for the pull request, @mzschwartz5! ✅ We can confirm we have a CLA on file for you. |
mzschwartz5
commented
Jul 14, 2026
Comment on lines
+73
to
+82
| // Add each ClippingPolygon object. | ||
| const polygons = options.polygons; | ||
| let numVertices = 0; | ||
| if (defined(polygons)) { | ||
| const polygonsLength = polygons.length; | ||
| for (let i = 0; i < polygonsLength; ++i) { | ||
| this._polygons.push(polygons[i]); | ||
| numVertices += polygons[i].length; | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Note: this was just hoisted up from the bottom of the constructor to be nearer to relevant code. I did, however, add the numVerticescounter.
mzschwartz5
force-pushed
the
clipping-polygon-buffer-migration
branch
2 times, most recently
from
July 15, 2026 21:42
03539d0 to
dcabaa5
Compare
mzschwartz5
changed the base branch from
main
to
DanielZ/feat/vector-terrian-polygon
July 15, 2026 21:42
8 tasks
mzschwartz5
force-pushed
the
clipping-polygon-buffer-migration
branch
from
July 17, 2026 20:57
dcabaa5 to
06fb8bd
Compare
This was referenced Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is the first step in reimplementing Clipping Polygon workflows on top of the Vector data pipeline. This PR simply introduces a write-through copy of a
ClippingPolygonCollection's polygon data in the form of aBufferPolygonCollection. Eventually, this will be the only backing data structure. It will be used with theVectorPipelineclass to generate textures used for the new vector-style clipping approach.Issue number and link
https://github.com/iTwin/cesiumjs-web3d-internal/issues/31
Testing plan
This PR introduces no behavioral changes, and thus there are no spec changes. Regression tests suffice: this sandcastle, for instance, or the clipping performance dev sandcastle.
Author checklist
CONTRIBUTORS.mdCHANGES.mdwith a short summary of my changeAI acknowledgment
If yes, I used the following Tools(s) and/or Service(s):
If yes, I used the following Model(s):
PR Dependency Tree
This tree was auto-generated by Charcoal