fix(sdk): retry captcha-request on 422 'Session not active' race#5
Open
iWedmak wants to merge 1 commit into
Open
fix(sdk): retry captcha-request on 422 'Session not active' race#5iWedmak wants to merge 1 commit into
iWedmak wants to merge 1 commit into
Conversation
After rent() the back marks the session 'active' immediately, but the provider WS attach on the relay lands a few hundred ms later. Calling request-captcha in that window returns 422 'Session not active' from AgentCaptchaRequestController. Retry up to 5 times with backoff 0.5/1/2/4s when the 422 body matches 'Session not active'. Other 422 bodies (validation, 'not configured') are still treated as terminal.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
browser.request_captcha()callsPOST /api/agent/sessions/{id}/captcha-requestright afterrent(). The back marks the sessionactiveimmediately, but the provider-WS attach on the relay lands a few hundred ms later — in that window the back returns 422 'Session not active'.Retry up to 5 times with backoff 0 / 0.5 / 1 / 2 / 4s when the 422 body matches
Session not active. Other 422 bodies (validation, 'not configured') stay terminal.Why
Without this, a tight
rent() → request_captcha()chain fails ~100% of the time on dev. SDK callers shouldn't have to sleep before the first action.Test plan
ceki rent --schedule N && ceki request-captcha <SID>succeeds without manual sleeptests/test_captcha.pystill green