Hopefully fixes end of round runtimes and the lags that possibly result because of it - #558
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Rewrote the end round thing just a bit to be safer hopefully, by checking if we have a client first, and if not, then check if we have a controller, and if so, then try to set the ai mode. No modularization because if it works it's going upstream
Developer's checklist
Testing Evidence
Prod
Why It's Good For The Game
At the end of most rounds, the game dies for a solid half a minute during which the end title credits should play but instead the game goes on as normal. This is the only runtime I could have found. Hope this fixes it? Silly deadites and their incomplete implementation.
Changelog
🆑
fix: MobAI is now checked before being set
/:cl: