Makes the painter ritual ask for a random person until it finds one - #557
Open
Ldip999 wants to merge 2 commits into
Open
Makes the painter ritual ask for a random person until it finds one#557Ldip999 wants to merge 2 commits into
Ldip999 wants to merge 2 commits into
Conversation
Ketrai
reviewed
Jul 27, 2026
| valid_targets += H | ||
|
|
||
| if(length(valid_targets)) | ||
| return pick(valid_targets) |
There was a problem hiding this comment.
It already picks a random target.
If you're seeing the same target, it might be because there's only one valid target, or a coincidence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Shuffles the player list before sifting through it for painter quests
Not going to modularize it because it will probably be submitted upstream once or at the very least tell Ketrai
Developer's checklist
Testing Evidence
Prod
Why It's Good For The Game
Don't believe it was intended to be a single person only
Changelog
🆑
fix: Abyssorite ritual now picks from random targets
/:cl: