[Paintroid-515] Use Paintroid keys for translations#161
Conversation
Lenkomotive
left a comment
Lenkomotive
left a comment
There was a problem hiding this comment.
solid work 👍🏼 pls also fix conflicts
| import 'package:intl/intl.dart' as intl; | ||
| import 'app_localizations.dart'; | ||
|
|
||
| // ignore_for_file: type=lint |
There was a problem hiding this comment.
can this be removed if we convert the keys to camelCase: pocketpaint_app_name -> pocketpaintAppName? snake_case is not flutter/dart convention
There was a problem hiding this comment.
those files are generated automatically, changing from snake_case to camelCase didnt change it, nevertheless i changed the keys to camelCase
| String get dialog_smoothing => 'Glättung'; | ||
|
|
||
| @override | ||
| String get dialog_zoom_window_enabled => 'Enabled'; |
There was a problem hiding this comment.
Some keys are still english, pls check.
| findsOneWidget); | ||
|
|
||
| final okButton = find.widgetWithText(TextButton, 'OK'); | ||
| final okButton = find.widgetWithText(TextButton, 'DONE'); |
There was a problem hiding this comment.
Some tests still use hardcoded values, pls check the testfiles again for incosistencies.
| @@ -0,0 +1,6 @@ | |||
| arb-dir: assets/lang | |||
| template-arb-file: app_translations_en.arb | |||
|
|
|||
There was a problem hiding this comment.
Add nullable-getter: false and strip the ! from every callsite. dart analyze lists 30 unnecessary_non_null_assertion warnings.
2 participants
This pull request refactores the app to use localization keys similar to the ones used in the Paintroid-Kotlin project.
Jira Link
New Features and Enhancements
Refactorings and Bug Fixes
Checklist
Your checklist for this pull request
Please review the contributing guidelines and wiki pages of this repository.