PAINTROID-514 Zoom level and position should be reset when creating a new image#143
Open
Amit-Matth wants to merge 4 commits into
Open
PAINTROID-514 Zoom level and position should be reset when creating a new image#143Amit-Matth wants to merge 4 commits into
Amit-Matth wants to merge 4 commits into
Conversation
Refactors the new-image canvas reset to bump a counter on CanvasStateData that DrawingCanvas listens to via ref.listen, instead of having the widget register a callback onto the keep-alive state provider. The previous mechanism had two latent crashes: - A late non-null callback that threw LateInitializationError if newImage() ran before DrawingCanvas mounted (e.g. cold-start file-open flows). - The closure outlived the State on a keep-alive provider, so any rebuild of DrawingCanvas left a callback referencing a disposed context. It also inverted layering by storing a UI method reference on a core/state provider.
# Conflicts: # lib/core/providers/object/io_handler.dart
The file_handler MethodChannel introduced in Catrobat#146 is implemented only on Android. On iOS, invokeMethod raises MissingPluginException (distinct from PlatformException, not a subclass), which the existing try block did not catch. main() crashed before runApp(), leaving the app stuck on a white screen. Catch MissingPluginException explicitly and no-op, since file open-from-Files is not supported on iOS yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a callback mechanism to CanvasStateProvider to reset canvas zoom and position when creating a new image. The canvas now properly resets to default zoom level (0.85) and centered position instead of persisting the previous image's view state.
PAINTROID-514
New Features and Enhancements
Refactorings and Bug Fixes
resetCanvasScaleCallbackto CanvasStateProviderIOHandler.newImage()to trigger canvas scale resetDrawingCanvas.initState()Implementation based on closed PR #21
Checklist
Your checklist for this pull request
Please review the contributing guidelines and wiki pages of this repository.