CATROID-1554: Refactor WaitForSoundAction to Kotlin#5193
Open
harshsomankar123-tech wants to merge 4 commits intoCatrobat:developfrom
Open
CATROID-1554: Refactor WaitForSoundAction to Kotlin#5193harshsomankar123-tech wants to merge 4 commits intoCatrobat:developfrom
harshsomankar123-tech wants to merge 4 commits intoCatrobat:developfrom
Conversation
dorianpercic
approved these changes
Apr 10, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors WaitForSoundAction from Java to Kotlin to support the ongoing Kotlin migration while keeping existing Java call sites (e.g., ActionFactory, instrumentation tests) working.
Changes:
- Replaced
WaitForSoundAction.javawithWaitForSoundAction.ktusing Kotlin null-safety and idiomatic constructs. - Kept Java interoperability via generated property setters and a
@JvmFieldTAG. - Updated header copyright year to 2026 in the new Kotlin file.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| catroid/src/main/java/org/catrobat/catroid/content/actions/WaitForSoundAction.kt | Kotlin implementation of the wait-for-sound behavior, including SoundManager/MidiSoundManager interactions. |
| catroid/src/main/java/org/catrobat/catroid/content/actions/WaitForSoundAction.java | Removed legacy Java implementation after Kotlin replacement. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



JIRA Ticket
https://catrobat.atlassian.net/browse/CATROID-1554
Description
This PR refactors the
WaitForSoundActionclass from Java to Kotlin as part of the ongoing effort to modernize the Catroid codebase. The implementation focuses on idiomatic Kotlin patterns and strict null safety while ensuring complete interoperability with existing Java components.Changes
WaitForSoundAction.javatoWaitForSoundAction.kt.!!operator.inoperator for set containment and property access syntax.ActionFactory) by ensuring property setters are properly exposed and using@JvmFieldfor theTAG.WaitForSoundAction.javafile.Testing
WaitForSoundActionTest.java).Your checklist for this pull request
Please review the contributing guidelines and wiki pages of this repository.