Comms uplift#686
Merged
SergeBakharev merged 5 commits intoJul 19, 2026
Merged
Conversation
Contributor
Author
|
I'm noticing a race condition for the continuous jogging keep alive. Fixing.... |
…ging stop condition with a wait for firmware ack
SergeBakharev
commented
Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Resolves: #560 #491
I tested with the Makera native firmware on the machine, as well as both modes from the new switchable code from PR343
It was even able to update the machine firmware from running 1.0.6 Makera to our Community version. So I'm pretty confident in all that.
Where I'm less confident is in the protocol abstraction, so in future we can implement our own thing. I'm having difficulty imagining what that might look like, probably doesn't have to be perfect today. But I would still appreciate those comments.
As part of the USB changes I made it filter the USB device selection to just the FTDI chip, and record the device serial to config for reconnect. This works well on my MacOS machine, if someone can help test this on Windows that would be awesome