Load and show tool geometry / info in the 3D viewer#685
Draft
Lyrkan wants to merge 10 commits into
Draft
Conversation
Contributor
|
I like the approach. It would be good to have the tool description in the popup for manual tool loading on the non-atc machines |
Contributor
Author
Yep, that's a good idea, I implemented a first version of it. I also added a parser for Makera Studio based on the few samples of gcode files I've seen posted on Discord (so it's probably wrong on some things but hard to verify without access to it). They seem to contain more info than what we currently have for Fusion (shank diameter and flute length for instance), which makes it a bit easier since we don't have to guess or make up values. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Related to #419
I'll add some more details here when I get the time to do so but this PR adds a way to extract tools information from the comments added by CAMs post-processors in order to display them and have more accurate representations in the 3D viewer.
The idea is that for each supported post-processor we would just have to need to add a specific parser in
carveracontroller/addons/tool_visualization/parsers/that detects tool descriptions comments and convert them to a commonToolDefinitionobject.For now I only created one for Fusion as a proof-of-concept (edit: also added something for Makera Studio) using the current post-processor format (which will probably need to be improved to replace localized string by constants, and maybe add a few extra parameters if we can such as thread pitch/diameter). @faecorrigan Since you worked a lot on post-processors does it sounds like a good way to handle that? Do all of them allow to expose at least some basic info?
The tools icons are only displayed if a parser detected at least one tool description and if there is enough space for them. The images could probably be improved since I didn't spend a lot of time on them.
I also added some tooltips on those buttons to display more details about each tool.
Some screenshots:
Tooltip on hover (screenshot doesn't show the cursor but it's on the first button):

Manual tool change modal (screenshot is not up to date):

Ball endmill:

Chamfer (or any kind of pointy) endmill:

Flat-end endmill:

Radius endmill:

Thread endmill:

Lollipop endmill:

Tapered endmill:

Using Makera Studio format:
