Skip to content

Correct Anchor 2 calibration title #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
righteousgambit wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Correct Anchor 2 calibration title #682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
- Fixed: Show the correct Anchor 2 title in the calibration operation list
- Enhancement: Add multi-select to the remote file browser
- Enhancement: Display error message in halt popup. Requires halt errors to start with "ERROR: " in the firmware
- Enhancement: Add popup notice when using stock firmware instead of the Community Firmware
Expand Down
2 changes: 1 addition & 1 deletion carveracontroller/addons/probing/operations/Calibration/CalibrationOperationType.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@ class CalibrationOperationType(Enum):
FourthY = CalibrationOperationFourthY("Calibration - FourthY", False, False, False, "")
FourthZ = CalibrationOperationFourthZ("Calibration - FourthZ", True, False, False, "")
Anchor1 = CalibrationOperationAnchor1("Calibration - Anchor1", False, False, False, "")
Anchor2 = CalibrationOperationAnchor2("Calibration - Anchor1", False, False, False, "")
Anchor2 = CalibrationOperationAnchor2("Calibration - Anchor2", False, False, False, "")
9 changes: 9 additions & 0 deletions tests/unit/test_calibration_operation_type.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
"""Tests for calibration operation labels."""

from carveracontroller.addons.probing.operations.Calibration.CalibrationOperationType import (
CalibrationOperationType,
)


def test_anchor2_operation_uses_anchor2_title():
assert CalibrationOperationType.Anchor2.value.title == "Calibration - Anchor2"
Comment on lines +8 to +9

@Lyrkan Lyrkan Jul 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure that change really warrants a dedicated unit test

Loading