Sanitize WHB04 spindle display values#681
Draft
righteousgambit wants to merge 2 commits into
Draft
Conversation
Contributor
|
Same as #677 (comment) |
Author
|
Addressed in The Quality Gate now runs Local verification on the updated branch:
The exact-head Quality Gate run is currently |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #672
Summary
curspindlewith a zero defaultfloat's range, to the WHB04 setter's0..65535rangeThe change only sanitizes what is shown on the pendant. It does not write CNC state or issue a spindle command.
Validation
Validated against
develop@2ea66c10e96d88013a04441134d3d4f8e8c88510with Python 3.11:OverflowErrorruff checkpassed for the source and testgit diff --checkpassedTargeted command:
Changelog
- Fixed: Sanitize missing or malformed spindle values before updating the WHB04 displayReal branch verification
The repository's locked Poetry environment was installed from
poetry.lock. The targeted suite passed on real fork commit75dc25352e51, whose sole parent is pinned upstreamdevelop@2ea66c10e96d88013a04441134d3d4f8e8c88510.Result: 11 passed.
Quality gates on the real branch:
check: passedformat --check: passedgit diff --check 2ea66c10e96d88013a04441134d3d4f8e8c88510..75dc25352e51dbe834d00378715a6f516e2b19b0: passed