Send complete XMODEM frames over Wi-Fi#676
Draft
righteousgambit wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #667
What changed
socket.send()inWIFIStream.putc()withsocket.sendall().len(data)aftersendall()completes, preserving the XMODEM callback's integer success contract.Why
sendall()Python documents that
socket.send()may send only part of the supplied data and leaves the remainder to the application.socket.sendall()continues until all bytes have been sent or an error occurs, which is the contractXMODEM.send()expects from this callback.Impact and compatibility
The wire format and XMODEM CRC behavior are unchanged. This closes a reliability gap that could cause retries, timeouts, or transfer failure after a partial socket write. CRC validation prevents a truncated frame from being silently accepted, so the change does not claim to fix demonstrated undetected corruption.
Validation
Pinned
develop(2ea66c10e96d88013a04441134d3d4f8e8c88510) against the new regression:Corrected implementation:
The passing test verifies all of the following:
send()is never called;sendall()is called exactly once; andputc()returns8199.Quality checks:
Real branch verification
The repository's locked Poetry environment was installed from
poetry.lock. The targeted suite passed on real fork commit8c9bb6c8ba77, whose sole parent is pinned upstreamdevelop@2ea66c10e96d88013a04441134d3d4f8e8c88510.Result: 1 passed.
Quality gates on the real branch:
check: passedformat --check: passedgit diff --check 2ea66c10e96d88013a04441134d3d4f8e8c88510..8c9bb6c8ba771e47e1101e23b2864001d15ea20d: passed