Verify XMODEM downloads against advertised MD5#675
Draft
righteousgambit wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #666
What changed
Nonewhen the advertised digest is absent or does not match.0, empty output, three CAN writes).Protocol compatibility
The receiver continues to ACK EOT on the wire. The behavioral change is local: a transfer whose bytes do not match the machine-advertised MD5 is no longer reported as successful to
download_file().Validation
Pinned
develop(2ea66c10e96d88013a04441134d3d4f8e8c88510) against the new tests:The truncated-transfer assertion observes
8192instead ofNone; the uppercase-local-MD5 test observes a completed transfer instead of the cache short-circuit.Corrected implementation:
Quality checks:
Real branch verification
The repository's locked Poetry environment was installed from
poetry.lock. The targeted suite passed on real fork commitf96ceccf1615, whose sole parent is pinned upstreamdevelop@2ea66c10e96d88013a04441134d3d4f8e8c88510.Result: 3 passed.
Quality gates on the real branch:
check: passedformat --check: passedgit diff --check 2ea66c10e96d88013a04441134d3d4f8e8c88510..f96ceccf161516a5e02c2eb995b1b7661aba644b: passed