fix(sonar): reduce quality gate noise#2350
Conversation
|
Warning Review limit reached
More reviews will be available in 54 minutes and 10 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (8)
Comment |
Merging this PR will not alter performance
Comparing Footnotes
|
90d6dd3 to
0a05025
Compare
0a05025 to
c664b6e
Compare
c664b6e to
6decc02
Compare
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
42Clownfish
left a comment
There was a problem hiding this comment.
Reviewed the Sonar cleanup patch. No blocker in the changed logic: the added exclusions are scoped to generated SQL/migrations and generated Android shell; store metadata still only normalizes title suffixes after the existing official-host URL validation path; JWT/base64url, PostHog, and Stripe slash/ID changes preserve behavior while avoiding hotspot regex/PRNG patterns; the keyboard handlers add Enter/Space activation without changing click behavior; CI is green.
Residual process risk is that generated SQL now depends on SQLFluff/migration review rather than Sonar, so migration diffs still need manual/DB-test review. Also GitHub currently marks this PR as conflicting, so it needs a rebase before merge.
6decc02 to
01510b6
Compare
01510b6 to
fea636c
Compare
|



Summary (AI generated)
Motivation (AI generated)
SonarCloud showed the quality gate failing on new reliability rating, new security rating, and reviewed security hotspots. The biggest ranking damage came from generated PostgreSQL SQL being analyzed as PL/SQL, plus a small set of regex, random, and accessibility findings in app/backend code.
Business Impact (AI generated)
Restoring the Sonar quality gate protects Capgo's public code quality signal and keeps noisy static-analysis debt from hiding real product risks.
Test Plan (AI generated)
bun run buildbun run lintbun run lint:backendbun typecheckgit diff --checkScreenshots (AI generated)
No UI screenshots. The visible UI behavior is unchanged except keyboard activation now works on the existing default-channel controls.
Checklist (AI generated)
bun run lint:backend && bun run lint.Generated with AI